Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velodyne_launch_all_hw.xml settings do not propagate to /velodyne_driver_ros_wrapper_node #143

Closed
bgilby59 opened this issue Apr 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bgilby59
Copy link
Contributor

After changing default values for cloud_min_angle to 270 and cloud_max_angle to 90 in velodyne_launch_all_hw.xml and then running ros2 launch nebula_ros nebula_launch.py sensor_model:=VLP32 launch_hw:=false, if I run ros2 param dump /velodyne_driver_ros_wrapper_node, I see the default values for cloud_min_angle and cloud_max_angle in the output:

    cloud_max_angle: 360
    cloud_min_angle: 0

Shouldn't the values I changed in the launch file propagating down to /velodyne_driver_ros_wrapper_node?

@bgilby59 bgilby59 added the bug Something isn't working label Apr 26, 2024
@bgilby59 bgilby59 changed the title velodyne_launch_all_hw.xml Settings Do Not Propagate to /velodyne_driver_ros_wrapper_node velodyne_launch_all_hw.xml settings do not propagate to /velodyne_driver_ros_wrapper_node Apr 26, 2024
@mojomex
Copy link
Collaborator

mojomex commented Sep 26, 2024

Fixed in #148.

@mojomex mojomex closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants