fix:　disable default argument value for include_oppsite_direction in …

…HdMapUtils::getLeftLaneletIds/getRightLaneletIds
tier4 · Dec 10, 2024 · 2ebc41a · 2ebc41a
1 parent 9e4fdaf
commit 2ebc41a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/simulation/traffic_simulator/include/traffic_simulator/hdmap_utils/hdmap_utils.hpp b/simulation/traffic_simulator/include/traffic_simulator/hdmap_utils/hdmap_utils.hpp
@@ -204,7 +204,7 @@ class HdMapUtils
 
   auto getLeftLaneletIds(
     const lanelet::Id, const traffic_simulator::RoutingGraphType,
-    const bool include_opposite_direction = false) const -> lanelet::Ids;
+    const bool include_opposite_direction) const -> lanelet::Ids;
 
   auto getLongitudinalDistance(
     const traffic_simulator_msgs::msg::LaneletPose & from_pose,
@@ -269,7 +269,7 @@ class HdMapUtils
 
   auto getRightLaneletIds(
     const lanelet::Id, const traffic_simulator::RoutingGraphType,
-    const bool include_opposite_direction = false) const -> lanelet::Ids;
+    const bool include_opposite_direction) const -> lanelet::Ids;
 
   auto getRightOfWayLaneletIds(const lanelet::Ids &) const
     -> std::unordered_map<lanelet::Id, lanelet::Ids>;

diff --git a/simulation/traffic_simulator/src/hdmap_utils/hdmap_utils.cpp b/simulation/traffic_simulator/src/hdmap_utils/hdmap_utils.cpp
@@ -220,11 +220,12 @@ auto HdMapUtils::countLaneChanges(
 
       if (auto followings = getNextLaneletIds(previous, routing_configuration.routing_graph_type);
           std::find(followings.begin(), followings.end(), current) == followings.end()) {
-        if (auto lefts = getLeftLaneletIds(previous, routing_configuration.routing_graph_type);
+        if (auto lefts =
+              getLeftLaneletIds(previous, routing_configuration.routing_graph_type, false);
             std::find(lefts.begin(), lefts.end(), current) != lefts.end()) {
           lane_changes.first++;
         } else if (auto rights =
-                     getRightLaneletIds(previous, routing_configuration.routing_graph_type);
+                     getRightLaneletIds(previous, routing_configuration.routing_graph_type, false);
                    std::find(rights.begin(), rights.end(), current) != rights.end()) {
           lane_changes.second++;
         }