-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider road slope in ego vehicle simulation #1182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
…tity simulation Signed-off-by: Kotaro Yoshimoto <[email protected]>
…pe in ego entity simulation Signed-off-by: Kotaro Yoshimoto <[email protected]>
…or simple_sensor_simulator Signed-off-by: Kotaro Yoshimoto <[email protected]>
…le_model # Conflicts: # simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp # test_runner/scenario_test_runner/launch/scenario_test_runner.launch.py
Signed-off-by: Kotaro Yoshimoto <[email protected]>
HansRobo
added
the
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
label
Feb 15, 2024
HansRobo
added
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
and removed
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
labels
Feb 15, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
…to getMatchedLaneletPoseFromEntityStatus function
hakuturu583
requested changes
Feb 21, 2024
simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/src/vehicle_simulation/ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Masaya Kataoka <[email protected]>
…entity_simulation.cpp Co-authored-by: Masaya Kataoka <[email protected]>
…entity_simulation.cpp Co-authored-by: Masaya Kataoka <[email protected]>
…entity_simulation.cpp Co-authored-by: Masaya Kataoka <[email protected]>
…entity_simulation.cpp Co-authored-by: Masaya Kataoka <[email protected]>
…entity_simulation.cpp Co-authored-by: Masaya Kataoka <[email protected]>
Co-authored-by: Masaya Kataoka <[email protected]>
… into feature/slope_vehicle_model
hakuturu583
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
We started to consider road slope in lanelet2 map.
In this pull-request, we consider about gravity effect at road slope in ego vehicle simulation.
Background
In horizontal road, gravity has no effect to vehicle behavior.
But in the sloped road, the gravity has some horizontal component to the road like the figure below.
This gravity component effects to the vehicle simulation behavior especially like acceleration and deceleration.
Details
The algorithm to consider sloped road
consider_acceleration_by_road_slope
flag to toggle functionIt is togglable to enable and disable the consideration of sloped road in ego vehicle simulation by using
consider_acceleration_by_road_slope
flag.The flag can be set in arguments of
ros2 launch
like below.ros2 launch scenario_test_runner scenario_test_runner.launch.py \ architecture_type:=awf/universe \ record:=false \ scenario:='$(find-pkg-share scenario_test_runner)/scenario/sample.yaml' \ sensor_model:=sample_sensor_kit \ vehicle_model:=sample_vehicle \ consider_acceleration_by_road_slope:=true
To ensure backward-compatibility, this flag is set to
false
defaultly.Subsequent changes
This pull-request does not implement all consideration to sloped road.
I am implementing the remaining changes on #1103.
By the way, the flag name
consider_acceleration_by_road_slope
is counterpart toconsider_pose_by_road_slope
, which will be introduced in #1103.References
pull-requests that were the basis for the change
Destructive Changes
There is no destructive changes because default behavior has not changed.
The regression test are done with default flag ( INTERNAL LINK )
Known Limitations
In this pull-request, we did not considered about lane lateral slope and lateral accelerration effect to vehicle model.
If
simple_planning_simulator
inautoware.universe
started to support them,scenario_simulator_v2
will start that too.