Fix/lanelet matching distance #1208
Merged
+23
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
hakuturu583
reviewed
Mar 12, 2024
| @@ -331,6 +331,7 @@ class API | |||
| FORWARD_TO_ENTITY_MANAGER(getRelativePose); | |||
| FORWARD_TO_ENTITY_MANAGER(getStandStillDuration); | |||
| FORWARD_TO_ENTITY_MANAGER(getTraveledDistance); | |||
| FORWARD_TO_ENTITY_MANAGER(getDefaultMatchingDistanceForLaneletPoseCalculation); | |||
| FORWARD_TO_ENTITY_MANAGER(getV2ITrafficLight); | |||
| FORWARD_TO_ENTITY_MANAGER(getV2ITrafficLights); | |||
| FORWARD_TO_ENTITY_MANAGER(isEgoSpawned); | |||
There was a problem hiding this comment.
It is a very small change, so it is unnecessary to retry Autoware Evaluator.
…private functions Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix adds the usage of default matching distance of each entity for
setEntityStatusfunctions that are run by teleport action in open scenario.Abstract
Default lane matching distance depends on entity type and is used in various places in the code. The default distance was not used in all possible situations.
Background
The default lane matching distance was added to the scenario simulator in PR #1194. However, the distance usage was not applied to all possible situations.
Details
Default lane matching distance of each entity was not used in open scenario teleport action and the default distance of
1.0was used. This fix adds the default lane matching distance to theAPI::setEntityStatusfunction, which is used in the open scenario teleport action.References
See #1194 for first default matching distance implementation.
INTERNAL ISSUE LINK
Destructive Changes
Known Limitations
The same limitations to the lane matching as before apply. The difference is that the default lane matching distance in teleport action is used, so it is slightly bigger than before (which was
1.0)