Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for autoware_auto_xx_msgs #1454

Merged
merged 106 commits into from
Dec 10, 2024
Merged

Drop support for autoware_auto_xx_msgs #1454

merged 106 commits into from
Dec 10, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Nov 18, 2024 •
edited
Loading

Description

Abstract

  • replace autoware_auto_xx_msgs with autoware_xx_msgs
  • use only one source for /autoware/state
  • finish supporting awf/autoware architecture_type ( traffic light for autoware_auto_perception_msgs )
  • use awf/autoware/20240605 as default architecture_type

Background

Details

simple message migrations

  • autoware_auto_vehicle_msgs -> autoware_vehicle_msgs
    • ControlModeReport.msg
    • GearReport.msg
    • SteeringReport.msg
    • TurnIndicatorsReport.msg
    • VelocityReport.msg
    • ControlModeCommand.srv
  • autoware_auto_perception_msgs -> autoware_perception_msgs
    • TrackedObjects.msg
    • TrackedObject.msg
    • DetectedObjects.msg
    • DetectedObject.msg
    • ObjectClassification.msg
    • DetectedObjectKinematics.msg
    • Shape.msg

complicated message migrations

1 vs 1

before after
autoware_auto_control_msgs/AckermannControlCommand autoware_control_msgs/Control
autoware_auto_planning_msgs/PathWithLaneId tier4_planning_msgs/PathWithLaneId
autoware_auto_map_msgs/HADMapBin autoware_map_msgs/LaneletMapBin

others

before after
autoware_system_msgs/AutowareState
autoware_auto_system_msgs/AutowareState		 autoware_system_msgs/AutowareState
autoware_auto_perception_msgs/TrafficSignalArray
autoware_perception_msgs/TrafficSignalArray
autoware_perception_msgs/TrafficLightGroupArray		 autoware_perception_msgs/TrafficSignalArray
autoware_perception_msgs/TrafficLightGroupArray

References

Destructive Changes

After this pull-request, scenario_simulator_v2 does not support autoware_auto_xx_msgs for interfaces.
To use with autoware_auto_xx_msgs, please use older versions of scenario_simulator_v2.

Known Limitations

None

kielczykowski-rai and others added 30 commits February 29, 2024 13:04
@kielczykowski-rai
Port VelocityReport message
6a9d298
@kielczykowski-rai
Delete unused vehicle_state_command and vehicle_control_command
ac3898e
@kielczykowski-rai
Port TurnIndicatorsReport
6dbbedb
@kielczykowski-rai
Port TurnIndicatorsCommand
d3f0135
@kielczykowski-rai
Port SteeringReport
1b1ac5a
@kielczykowski-rai
Port GearReport
a65aede
@kielczykowski-rai
Port GearCommand
c4a68d2
@kielczykowski-rai
Port ControlModeReport
6fdbc90
@kielczykowski-rai
Adjust docs to autoware_auto_vehicle_msgs to autoware_vehicle_msgs port
6ebf21e
@kielczykowski-rai
Port AutowareState
376072e
@kielczykowski-rai
Port PathWithLaneId
7636e3c
@kielczykowski-rai
Finish porting autoware_auto_planning_msgs to autoware_planning_msgs
af9bf3e
@kielczykowski-rai
FIX: replace old Trajectory message with tier4_autoware_msgs which is…
3a9bd9b 
… used in scenario_simulator_v2
@kielczykowski-rai
Port HADMapBin to LaneletMapBin
4b92172
@kielczykowski-rai
Port AckermannControlCommand to Control
6fffa05
@kielczykowski-rai
Port TrafficSignalArray from autoware_auto_perception_msgs to autowar…
735258a 
…e_perception_msgs
@kielczykowski-rai
Update documentation
d69a1e8
@kielczykowski-rai
PathWithLaneId: change autoware_msgs to tier4_planning_msgs
2c03a14
@kielczykowski-rai
Concealer: Delete unused autoware_planning_msgs
3588c05
@kielczykowski-rai
Port DetectedObjects and TrackedObjects
89f3b89
@kielczykowski-rai
Delete unused autoware_auto_system_msgs package
6562e1e
@kielczykowski-rai
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
4ca6258 
…gs_support
@kielczykowski-rai
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
9c8dd4e 
…gs_support
@kielczykowski-rai
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
70fc9e5 
…gs_support
@kielczykowski-rai
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
33675ea 
…gs_support
@kielczykowski-rai
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
27d0fcf 
…gs_support
@HansRobo
feat(traffic_simulator): support TrafficLightGroupArray in TrafficLig…
6e6efbd 
…htPublisher
@HansRobo
feat(traffic_simulator): support TrafficLightGroupArray in SimpleSens…
282817a 
…orSimulator
@HansRobo
chore: delete autoware_auto_msgs from dependencies
8ad7666
@HansRobo
feat(traffic_simulator): support TrafficLightGroup for V2I traffic li…
a043751 
…ghts
@HansRobo
chore: delete wrongly doubled word
478928e
@HansRobo
refactor: added handling when autoware_perception_msgs/msg/traffic_si…
eb854fc 
…gnal_array.hpp is not present
@HansRobo
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
2198518 
…gs_support
@HansRobo
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
83229de 
…gs_support

# Conflicts:
#	simulation/traffic_simulator/src/traffic_lights/traffic_light_publisher.cpp
@HansRobo
chore: delete a test using autoware_auto_perception_msgs
3d0d7cf
@HansRobo
fix: replace "awf/universe" with "awf/universe/20240605" for architec…
d3b0d5c 
…ture_type
@HansRobo
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
868938a 
…gs_support
@HansRobo
chore: apply linter
b056d1a
@HansRobo
chore: apply linter
b65612a
@HansRobo
fix: DataTypes/stringFromArchitectureType_correct in random_test_runner
532a190
@HansRobo
Merge remote-tracking branch 'origin/master' into RJD-736/autoware_ms…
a4496e8 
…gs_support
@HansRobo
Merge branch 'master' into RJD-736/autoware_msgs_support
013b793
@HansRobo HansRobo self-assigned this Dec 10, 2024
@HansRobo HansRobo marked this pull request as ready for review December 10, 2024 05:49
@HansRobo HansRobo assigned yamacir-kit and hakuturu583 and unassigned HansRobo Dec 10, 2024
hakuturu583
hakuturu583 requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix problems pointed by sonarcloud.

https://sonarcloud.io/project/issues?id=tier4_scenario_simulator_v2&pullRequest=1454&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
9.9% Coverage on New Code
2.9% Duplication on New Code

See analysis details on SonarQube Cloud

@HansRobo HansRobo merged commit c984c4d into master Dec 10, 2024
15 checks passed
@github-actions github-actions bot deleted the RJD-736/autoware_msgs_support branch December 10, 2024 10:02
@HansRobo HansRobo restored the RJD-736/autoware_msgs_support branch December 10, 2024 10:03
@yamacir-kit yamacir-kit mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

@yamacir-kit yamacir-kit yamacir-kit approved these changes

Assignees

@yamacir-kit yamacir-kit

@hakuturu583 hakuturu583

Labels
bump major If this pull request merged, bump major version of the scenario_simulator_v2 interface breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HansRobo @yamacir-kit @hakuturu583 @kielczykowski-rai @youtalk