-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rviz Marker for some conditions #1457
Open
f0reachARR
wants to merge
18
commits into
master
Choose a base branch
from
feature/rviz/distance-display
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Quality Gate passedIssues Measures |
HansRobo
added
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
labels
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR will add Rviz Marker for ReachPositionCondition.
Background
Currently,
interpreter
does not expose its internal state for Rviz. However, there is a demand for showing state in Rviz for see internal state.Details
For efficiency, I added VisualizationBuffer and collect all markers in it.
To share VisualizationBuffer across each
Condition
syntax processor, I use singleton for it (likeSimulatorCore
).Example marker of ReachPositionCondition (red line for distance and green sphere for goal)
Known Limitations
As
traffic_simulator
andopenscenario_interpreter
are different package, distance line (red line between target position and current position) might not be accurate in case of using routing algorithm in distance calculation.