Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rviz Marker for some conditions #1457

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

f0reachARR
Copy link
Contributor

@f0reachARR f0reachARR commented Nov 21, 2024

Description

Abstract

This PR will add Rviz Marker for ReachPositionCondition.

Background

Currently, interpreter does not expose its internal state for Rviz. However, there is a demand for showing state in Rviz for see internal state.

Details

For efficiency, I added VisualizationBuffer and collect all markers in it.
To share VisualizationBuffer across each Condition syntax processor, I use singleton for it (like SimulatorCore).

Example marker of ReachPositionCondition (red line for distance and green sphere for goal)
image

Known Limitations

As traffic_simulator and openscenario_interpreter are different package, distance line (red line between target position and current position) might not be accurate in case of using routing algorithm in distance calculation.

Copy link

github-actions bot commented Nov 21, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@f0reachARR f0reachARR marked this pull request as ready for review November 28, 2024 02:19
@f0reachARR f0reachARR requested a review from HansRobo November 28, 2024 02:19
Copy link

sonarqubecloud bot commented Nov 28, 2024

@HansRobo HansRobo added bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants