-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add despawn_function argument #1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Jan 6, 2025
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: Masaya Kataoka <[email protected]>
…nction_in_constructor
…structor' into fix/pass_despawn_function_in_constructor
yamacir-kit
approved these changes
Jan 8, 2025
Quality Gate passedIssues Measures |
github-actions
bot
deleted the
fix/pass_despawn_function_in_constructor
branch
January 10, 2025 01:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Add
const std::function<void(const std::string &)> & despawn_function
argument to the TrafficSink/TrafficController class.Background
Fixed #1464 to call
EntityManager::despawnEntity
function instead ofAPI::despawn
function during PR review process.The
API::despawn
function included a function to communicate with sensor_simulator, and the function to delete Entity in sensor simulator via inter-process communication was implemented.The
EntityManager::despawnEntity
function has been changed to call theEntityManager::despawnEntity
function, so Entity in sensor simulator is no longer deleted.Details
Add
const std::function<void(const std::string &)> & despawn_function
argument to the TrafficSink/TrafficController class and passAPI::despawn
function in member initialize list of the API class.References
#1464
https://star4.slack.com/archives/C04TZBEABDM/p1735261646158039?thread_ts=1735102371.414719&cid=C04TZBEABDM
Regression test.
Destructive Changes
N/A
Known Limitations
The design of this PR is not desirable, but for now it is a PR to solve the problems that have occurred.
In the future, use the Job class to replace the TrafficSink/TrafficSource class for a more reasonable refactor.