Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix participant profile ame replacement #20

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jnippula
Copy link
Collaborator

Allow profile_name be in any position in participant tag definition instead of assuming it is the first argument

Cleanup one unnecessary list generation in line iteration

Allow profile_name be in any position in participant tag definition
instead of assuming it is the first argument

Cleanup one unnecessary list generation in line iteration
Copy link

@kidevuojarvi kidevuojarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jnippula jnippula merged commit e86fd95 into master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants