Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper vm name passing #10

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Aug 23, 2024

Description

Implement proper vm name passing

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

nix flake check or run-vm-test admin.

givc-cli .... start --vm vmname appname should start in vmname VM

avnik added 2 commits August 23, 2024 13:47
Signed-off-by: Alexander V. Nikolaev <[email protected]>
Signed-off-by: Alexander V. Nikolaev <[email protected]>
@avnik avnik force-pushed the avnik/proper-vm-name-passing branch from 6429a5f to 1fcc8e3 Compare August 23, 2024 15:39
@mbssrc mbssrc merged commit 9ffd346 into tiiuae:main Aug 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants