Locale and timezone setting support #18
Conversation
Add SetLocale and SetTimezone methods to givc-admin for changing the system settings. When set, the value are stored to a configuration file, and reported back to agents when they register. Adjust givc-agent to handle the timezone and locale settings repotrted by the admin; use systemd's localectl, timedatectl and systemctl set-environment to apply the settings. Add policykit policy to allow locale and timezone setting to the givc user. Signed-off-by: Santtu Lakkala <[email protected]>
Signed-off-by: Santtu Lakkala <[email protected]>
Change locale and timezone to be signalled from admin to agent after registration. Signed-off-by: Santtu Lakkala <[email protected]>
Signed-off-by: Santtu Lakkala <[email protected]>
slakkala
force-pushed
the
dev/locale-timezone
branch
from
0ff57cd to
c7894e9
Compare
Signed-off-by: Santtu Lakkala <[email protected]>
client/src/client.rs
Outdated
| use tokio_stream::StreamExt; | ||
| use tonic::transport::Channel; | ||
| use tracing::debug; | ||
|
|
||
| use givc_common::address::EndpointAddress; | ||
| use givc_common::pb; |
There was a problem hiding this comment.
I (started) grouped imports intentionally -- std, libraries, project crates, this crates import (internally alphabetically sorted)
There was a problem hiding this comment.
Ah, yes, this got messed up in a rebase.
| enable = true; | ||
| extraConfig = '' | ||
| polkit.addRule(function(action, subject) { | ||
| if (action.id == "org.freedesktop.locale1.set-locale" && subject.user == "ghaf") { |
There was a problem hiding this comment.
Should username be hardcoded? Or we should have ghaf.username setting somewhere)
There was a problem hiding this comment.
Good question; I'll check.
There was a problem hiding this comment.
That broke standalone things, reverting for now.
| task: tokio::task::JoinHandle<()>, | ||
| } | ||
|
|
||
| impl Drop for WatchResult { |
There was a problem hiding this comment.
I am concerning about remove Drop here, I not sure if task spawned for polling grpc would shut down automatically, if WatchResult is destroyed.
There was a problem hiding this comment.
Without the Drop implementation, the spawned task will run until there is an event, at which point the recv will fail and task will terminate.
This was mainly for larger refactoring for helping interoperability with gtk-rs, but turned out it actually made things worse.
My main concern with this is that the WatchResult cannot be destructured, but I guess we can live with that.
There was a problem hiding this comment.
Changed it now to use a tokio mpsc channel for signalling; no need to explicitly implement Drop: when the (last, but in this case only) sender is dropped, the recv() -future will complete, and the task will terminate.
I did intentionally put them in separate commits, but yeah, maybe PRs would've been smarter. |
Signed-off-by: Santtu Lakkala <[email protected]>
slakkala
force-pushed
the
dev/locale-timezone
branch
2 times, most recently
from
5460358 to
e2ceb07
Compare
Description
Implement locale and timezone setting methods in givc-admin, and report the settings back to agents upon registration. Implement locale and timezone setting application in givc-agent (using localectl and timedatectl).
Checklist
nix flake check --accept-flake-configand it passesTesting