Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display management in gui-vm #20

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Display management in gui-vm #20

merged 1 commit into from
Oct 14, 2024

Conversation

gngram
Copy link
Contributor

@gngram gngram commented Oct 11, 2024

#Display management in gui-vm

Description

Start display-suspend.service on gui-vm when there suspend.target is triggered in host.
Start display-resume.service on gui-vm when there sleep.target is triggered in host.
Updated admin test.

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Successfully executed admin vm tests.

@gngram gngram requested a review from mbssrc October 11, 2024 10:10
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good, I added few minors comment

src/admin/server.rs Outdated Show resolved Hide resolved
src/admin/server.rs Outdated Show resolved Hide resolved
src/admin/server.rs Outdated Show resolved Hide resolved
src/admin/server.rs Outdated Show resolved Hide resolved
src/admin/server.rs Outdated Show resolved Hide resolved
@mbssrc mbssrc merged commit 8bf77b0 into tiiuae:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants