Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellany cleanups #24

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Miscellany cleanups #24

merged 3 commits into from
Oct 29, 2024

Conversation

slakkala
Copy link
Contributor

@slakkala slakkala commented Oct 28, 2024

Description

Remove unnecessary crate dependencies and sync versions to avoid duplicates.
Drop usage of deprecated function.
Minor code refactoring.

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

No functional changes.

Signed-off-by: Santtu Lakkala <[email protected]>
@slakkala slakkala requested review from avnik and mbssrc October 28, 2024 15:59
@mbssrc mbssrc merged commit f5ba65f into tiiuae:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants