Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cert #39

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update cert #39

merged 2 commits into from
Jan 23, 2025

Conversation

mbssrc
Copy link
Collaborator

@mbssrc mbssrc commented Jan 22, 2025

Description

Update certificate and key generation to generate an image file instead of copying to folder.
Allows to mount it read-only via microvm.volume.

Checklist

  • Summary of the proposed changes in the PR description
  • Test procedure added to nixos/tests
  • Author has run nix flake check and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Tested on ghaf

mbssrc added 2 commits January 23, 2025 02:53
@mbssrc
feat(cert-generation): Generate image files
81af434 
Generate image files instead of copying to a target folder.

Signed-off-by: Manuel Bluhm <[email protected]>
@mbssrc
Revert "Fix VM (re-)starting + test"
1d4dd0a 
This reverts commit 14b7af9.
@mbssrc mbssrc requested a review from avnik January 22, 2025 23:50
@mbssrc mbssrc merged commit a3aa677 into tiiuae:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnik avnik Awaiting requested review from avnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbssrc