Remove extra params for RF #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joinemm
requested changes
Dec 10, 2024
ghaf-hw-test.groovy
Outdated
Comment on lines
45
to
46
| // Pass the secrets to the shell as environment variables, as we | ||
| // don't want Groovy to interpolate them. Similary, we pass |
There was a problem hiding this comment.
Comment is no longer relevant
There was a problem hiding this comment.
should we leave some comment like this?
// Pass variables as environment variables to shell.
// Ref: https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#string-interpolation
Signed-off-by: Mariia Azbeleva <[email protected]>
azbeleva
force-pushed
the
secret_params
branch
from
7691019 to
82b98a8
Compare
joinemm
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be merged after tiiuae/ci-test-automation#178