Add slacking for failed builds #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mnokka-unikie <[email protected]>
mkaapu
requested changes
Jun 25, 2024
ghaf-main-pipeline.groovy
Outdated
| @@ -39,8 +39,26 @@ pipeline { | |||
| script { | |||
| env.TARGET_COMMIT = sh(script: 'git rev-parse HEAD', returnStdout: true).trim() | |||
| env.ARTIFACTS_REMOTE_PATH = "${env.JOB_NAME}/build_${env.BUILD_ID}-commit_${env.TARGET_COMMIT}" | |||
| env.GITHUBLINK="https://github.com/tiiuae/ghaf/commit/${env.TARGET_COMMIT}" | |||
| env.SERVER_NAME = sh(script: 'echo ${JENKINS_URL}', returnStdout: true).trim() | |||
| if (env.SERVER_NAME == "") { | |||
There was a problem hiding this comment.
Note: Not only here, but throughout the changes you have made.
henrirosten
reviewed
Jun 25, 2024
utils.groovy
Outdated
Comment on lines
155
to
166
| def determine_environment(serverName) { | ||
| def DEV_SLACK_CHANNEL = "ghaf-jenkins-builds-failed" | ||
| def PROD_SLACK_CHANNEL = "FALSE" // no slacking | ||
| def PRIVATE_SLACK_CHANNEL = "ghaf-jenkins-ci" | ||
| if (serverName.contains('prod')) { | ||
| return [env: 'prod', channel:PROD_SLACK_CHANNEL ] | ||
| } else if (serverName.contains('dev')) { | ||
| return [env: 'dev', channel:DEV_SLACK_CHANNEL ] | ||
| } else { | ||
| return [env:'priv', channel:PRIVATE_SLACK_CHANNEL ] | ||
| } | ||
| } |
There was a problem hiding this comment.
There are several problems with this function, most importantly, I don't think we can generally conclude the environment type based on the hostname or jenkins URL alone. I would propose the following:
- Completely remove this function
- Start with adding 'slacking' feature to one pipeline, perhaps to the
ghaf-main-pipeline.groovy - In the post step of the given pipeline, determine if 'slacking' is needed based on the hostname strict match (as returned by
uname -n). Only proceed with 'slacking' if hostname matchesghaf-jenkins-controller-dev
That way, you could greatly simplify the changes required and have all the 'slacking' changes only in the 'post' step.
Signed-off-by: mnokka-unikie <[email protected]>
|
closing, changes implemented top of current main in a new PR |
|
@mnokka-unikie : generally, you don't need to introduce a new PR to have it rebased on the new main. Simply rebase locally, then force-push to your branch and it will update the PR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slacks failed builds to defined channels. Currently dev and priv Jenkins have dedicated Slack channels defined for usage.