Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tar file of archived outputs #40

Closed
wants to merge 1 commit into from
Closed

Conversation

mkaapu
Copy link
Contributor

@mkaapu mkaapu commented Jul 26, 2024

Adds an option to download build output of target as a tar file.

@mkaapu mkaapu marked this pull request as draft July 26, 2024 14:36
@mkaapu
Copy link
Contributor Author

mkaapu commented Jul 26, 2024

This draft version works currently only with fmo-os-main-pipeline.groovy pipeline.
The archive_artifacts method is now intended to be used after all tests are done for single target to collect all outputs together.
This solution is also easiest to implement when targets are build in parallel branches, to avoid checking if build output is available or not, etc.

@mkaapu
Copy link
Contributor Author

mkaapu commented Jul 26, 2024

I tested these changes against already built changes, so I can better see how much this increase build times.
I tried tar with -J option first, but compressing 1 target with xz took just too much time in jenkins-controller (playground setup).
Then I tried with -z option (gzip), and FMO-OS build with 6 targets took 36 minutes. Still too much in my opinion.
Then I end up to current version without compression.
Building took 12 minutes. I think this is OK. Downside is used disk space in blob storage as output size is doubled.
So only benefit would be to provide a way to download all output files/directories for 1 target as a single tar file.

@mkaapu mkaapu requested a review from a team July 29, 2024 09:01
@henrirosten
Copy link
Collaborator

@mkaapu: Can we close this?

@mkaapu
Copy link
Contributor Author

mkaapu commented Dec 10, 2024

@mkaapu: Can we close this?

This can be closed. Our current handling of artifacts has probably already diverged significantly from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants