Add orin-nx and lenovo-x1 boot tests #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrirosten
reviewed
Aug 16, 2024
azbeleva
approved these changes
Aug 16, 2024
henrirosten
reviewed
Aug 16, 2024
henrirosten
reviewed
Aug 16, 2024
ghaf-test-boot.groovy
Outdated
Comment on lines
126
to
138
| if(["lenovo-x1"].contains(params.DEVICE_CONFIG_NAME)) { | ||
| echo "Wiping filesystem..." | ||
| def SECTOR = 512 | ||
| def MIB_TO_SECTORS = 20480 | ||
| // Disk size in 512-byte sectors | ||
| def SECTORS = sh(script: "sudo blockdev --getsz /dev/${dev}", returnStdout: true).trim() | ||
| // Unmount possible mounted filesystems | ||
| sh "sync; sudo umount -q /dev/${dev}* || true" | ||
| // Wipe first 10MiB of disk | ||
| sh "sudo dd if=/dev/zero of=/dev/${dev} bs=${SECTOR} count=${MIB_TO_SECTORS} conv=fsync status=none" | ||
| // Wipe last 10MiB of disk | ||
| sh "sudo dd if=/dev/zero of=/dev/${dev} bs=${SECTOR} count=${MIB_TO_SECTORS} seek=\$(( ${SECTORS} - ${MIB_TO_SECTORS} )) conv=fsync status=none" | ||
| } |
There was a problem hiding this comment.
We don't have to do it in this PR, but frankly, I think the details of how the flashing needs to happen should come from a script in Ghaf repo, so we would not have to worry about such details in the Jenkins pipeline.
There was a problem hiding this comment.
Yes this is just a working one for those new devices and let's improve this later.
Add orin-nx and lenovo-x1 boot tests to ghah-infra mainline. Signed-off-by: Ville-Pekka Juntunen <[email protected]>
vjuntunen
force-pushed
the
add_more_test_devices
branch
from
d7415ea to
1ce7d9c
Compare
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
henrirosten
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add orin-nx and lenovo-x1 boot tests to ghah-infra mainline.