Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Lenovo X1 Carbon release targets nightly #47

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mkaapu
Copy link
Contributor

@mkaapu mkaapu commented Aug 22, 2024

Building and testing of Lenovo X1 Carbon release targets added to the nightly pipeline.

@mkaapu mkaapu requested a review from a team August 22, 2024 09:31
@henrirosten
Copy link
Collaborator

This needs a rebase.
Also, do we need to run sbomnix, provenance, and vulnxscan for the release targets you added, or could we skip it to save time?

@mkaapu mkaapu force-pushed the pr-add-lenovo-release-nightly branch from c000e22 to dbc1f47 Compare August 23, 2024 13:04
@mkaapu
Copy link
Contributor Author

mkaapu commented Aug 23, 2024

This needs a rebase. Also, do we need to run sbomnix, provenance, and vulnxscan for the release targets you added, or could we skip it to save time?

Rebased.

Nightly builds are probably the best way to check that everything works in main branch before we start making releases. And at some point, release targets are probably more important targets to check than debug targets. I think we need to follow the needs of development team and/or what will be released. if we have resources we should support all targets with full coverage tests.

Anyway, build took 4 hours and 21 minutes. I think it is OK for nightly build. I leave those checks here for now.

@mkaapu mkaapu merged commit 74aed36 into tiiuae:main Aug 23, 2024
1 check passed
@mkaapu mkaapu deleted the pr-add-lenovo-release-nightly branch August 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants