Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug version of X1 Carbon installer #62

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mkaapu
Copy link
Contributor

@mkaapu mkaapu commented Sep 9, 2024

Add Lenovo X1 Carbon (gen11) debug installer for nightly builds as requested by test team.

@mkaapu mkaapu requested a review from a team September 9, 2024 09:25
Copy link

@mnokka mnokka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

@henrirosten
Copy link
Collaborator

Can we drop the provenance, sbomnix, and vulnxscan for the .#packages.x86_64-linux.lenovo-x1-carbon-gen11-debug-installer you added, or do they need to have the scs content for that target too?

@mkaapu
Copy link
Contributor Author

mkaapu commented Sep 9, 2024

Can we drop the provenance, sbomnix, and vulnxscan for the .#packages.x86_64-linux.lenovo-x1-carbon-gen11-debug-installer you added, or do they need to have the scs content for that target too?

Asked same question from Kai. We decided to include them. Anyway, we want one of our pipelines to verify and sign everything we are going to release. I think nightly builds are currently our best tool for that. They are nightly builds so building can take longer over night without taking resources from developers.

Not sure if these installers are part of release content though.

@mkaapu mkaapu merged commit f2a685a into tiiuae:main Sep 9, 2024
1 check passed
@mkaapu mkaapu deleted the pr-add-lenovo-debug-installer branch September 9, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants