Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pre-merge pipeline as failed if any target fails #72

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

joinemm
Copy link
Collaborator

@joinemm joinemm commented Sep 19, 2024

Reusing the error handling logic from utils.groovy. The reason we can't just use the nix_build from utils is that it's not equipped to deal with raw derivation paths, and expects a flake reference. There is also lot of unnecessary steps not suitable for parallel building, such as signing and artifact archiving.

@joinemm joinemm requested a review from a team September 19, 2024 10:08
@henrirosten
Copy link
Collaborator

> The reason we can't just use the nix_build from utils is that it's not equipped to deal with raw derivation paths, and expects a flake reference. There is also lot of unnecessary steps not suitable for parallel building, such as signing and artifact archiving.

Not necessary a topic of this PR, but:
I assume we are going to soon make the other pipelines (main, nightly, release) build parallel too, so we probably should modify the relevant functions in utils.groovy in such a way that they could be called from such parallel build pipelines too.

@joinemm
Copy link
Collaborator Author

joinemm commented Sep 19, 2024

yes, but for now this is the easier way to not break every other pipeline in the process

@joinemm joinemm merged commit e52d137 into tiiuae:main Sep 19, 2024
1 check passed
@joinemm joinemm deleted the pr-fail-pipeline branch September 19, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants