Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash script for each target artifacts #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnokka-unikie
Copy link
Contributor

Adding flash script to each but docs target artifiact directory

@joinemm
Copy link
Collaborator

joinemm commented Oct 30, 2024

Please fix inconsistent indentation and formatting

@henrirosten
Copy link
Collaborator

henrirosten commented Oct 31, 2024

This seems overly complicated to me.

If it's the same flash script for all of those targets, wouldn't it be far simpler if just copied the script (once) to the root of the build artifacts, e.g. here: https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/artifacts/ghaf-main-pipeline/build_12-commit_147f806264d2fb9d9026d4221b7cfbd69587bb61/, instead of placing it inside each target artifact directory?

@mnokka-unikie
Copy link
Contributor Author

Testers wanted to have copy in each target directory ("just one script copy approach was offered"). They "approved" the current solution, hence now we have development vs. user acceptance phenomena

@milva-unikie
Copy link

Hello from the testing team (& also from the user trials point of view)

Having a separate script for each target makes it a lot more easier to use. In the testing side we for sure could deal with that, but we also have now user trial participants that are using Artifacts. Many of them don't know what the different targets are or how Jenkins folders work. When the script is in the same folder as the image, we can just send one link and everything needed will be there.

@mkaapu
Copy link
Contributor

mkaapu commented Oct 31, 2024

If flashing scripts are something, we should also provide to end users, then they should also be part of target build output.
In this case with current implementation, we would need no changes to Pipeline scripts as they were simply archived with the rest of the build result files.

Copy link
Collaborator

@henrirosten henrirosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing to close this with the alternative resolution @mkaapu referenced above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants