Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split signing certs for image and provenance #85

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

alextserepov
Copy link
Contributor

The pipeline part

@alextserepov alextserepov requested a review from a team November 5, 2024 10:53
@henrirosten henrirosten self-requested a review November 5, 2024 11:02
@henrirosten
Copy link
Collaborator

@alextserepov: actually, should you change this here too:

utils.sign_file("archive/${img_relpath}", "sig/${img_relpath}.sig")

@alextserepov
Copy link
Contributor Author

@alextserepov: actually, should you change this here too:

utils.sign_file("archive/${img_relpath}", "sig/${img_relpath}.sig")

Thank you. Done!

@alextserepov
Copy link
Contributor Author

Modified the HW & parallel-HW test pipelines. So, have to re-request review.

@alextserepov alextserepov requested review from cazfi, joinemm, henrirosten and a team November 6, 2024 09:39
@joinemm
Copy link
Collaborator

joinemm commented Nov 6, 2024

please squash and rebase your commits

Signed-off-by: Aleksandr Tserepov-Savolainen <[email protected]>
@alextserepov alextserepov force-pushed the feature/sign-cert-split-pi branch from 67adc3d to a35aaf6 Compare November 6, 2024 10:12
@alextserepov
Copy link
Contributor Author

please squash and rebase your commits

Not that I see any difference between this and "squash and merge", but well ... done. ;)

@alextserepov alextserepov merged commit 217d9a1 into main Nov 7, 2024
1 check passed
@alextserepov alextserepov deleted the feature/sign-cert-split-pi branch November 7, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants