Added shared memory multi-server feature #917

jkuro-tii · 2024-11-28T07:53:16Z

Description of changes

The memsocket application has been enhanced with the following new features and updates:

Host Support:
    The application can now run on the host in addition to virtual machines (VMs).

Multi-Server Capability:
    Multiple memsocket instances operating in server mode are now supported.
    Each server instance is configured with a list of specific client IDs it serves.
    Multiple servers can run simultaneously on a single VM or the host.

Client ID Exclusivity:
    Each client ID must be managed by only one server across the entire system.

Configuration Updates:
    Renamed some Nix configuration options for clarity.

Option Changes:
    The -c and -s options have been swapped:
        -c: Now used for running in server mode.
        -s: Now used for running in client mode.
    A new -l option has been introduced for server mode to specify the list of client IDs to be serviced.   
    A new -h option has been introduced for indicating run on the host

Introduced a Nix framework for the automatic generation of configurations for servers (currently supporting audio and video) and their clients.
Enabled the transfer of audio and video data via shared memory from application VMs to designated servers, including gui-vm and audio-vm.

Documentation: https://confluence.tii.ae/x/uEPOAg

Checklist for things done

Instructions for Testing

List all targets that this applies to:
Is this a new feature
- List the test steps to verify:
If it is an improvement how does it impact existing functionality?

josa41 · 2024-11-28T12:36:39Z

Nothing too obvious to comment in the code.
I did test this also with pulseaudio and got everything to work just fine.
During my testing i found two issues.

If the application socket (pulseaudio in my tests) is not available when memsocket starts then data does not reach the socket. Restarting memsocket helps for this or adding a delay for memsocket to start after the application.
Memsocket/kernel crashes when a second memsocket server is started from command line on the same VM with another id

I passed more details to Jarek in slack

mbssrc · 2024-12-04T12:38:53Z

Any idea how this can or should be tested?

josa41 · 2025-01-09T11:59:33Z

Tested briefly and audio works through shared mem.
Had some trouble with permissions but that is not related to this change.

jkuro-tii · 2025-01-09T12:16:59Z

Currently, audio and GUI data are sent using shared memory. It's controlled by the enabled option - e.g.: source code
Testing should include running multiple services simultaneously and stopping them, such as Google Chrome, and other app VMs.

The testing process should focus on detecting potential file descriptor or socket leaks by stopping and restarting these services repeatedly.

Additional tests can be performed using any Unix sockets-enabled app, e.g., netcat.

Keep in mind that it requires allocating additional shared memory slots (the shmSlots option). It's possible to reuse already assigned slots, but it requires shutting down the server and client using it.

VM1: server

nc -lU socket_path &
memsocket -s socket_path -l xxx # xxx - allocated slot number

VM2: client

memsocket -c socket_path xxx & # xxx - allocated slot number
nc -U socket_path

leivos-unikie · 2025-01-13T14:51:27Z

Tested on Lenovo-X1

ci-test-automation results ok, performance ok
logging in and out
number of total open file descriptors varies between
audio-vm: 16
gui-vm: 0 (logged out) / 35 (logged in)
launching gui-vm apps
number of total open file descriptors varies between
chrome-vm: 16
audio-vm: 16
gui-vm: 35 (increasing to 40 over time)
launching chrome-vm and youtube video
number of total open file descriptors varies between
chrome-vm: 16 - 21
audio-vm: 16 - 20
gui-vm: 35 - 38
Launching all apps
number of total open file descriptors varies between
business-vm: 16 - 23
chrome-vm: 16 - 18
audio-vm: 16 - 19
gui-vm: 35 - 53

Detected problems:

VM apps (running outside gui.vm) don't launch after log out and log in. While studying the issue noticed at some point that there were a lot of waypipe* files in gui-vm /tmp

[ghaf@gui-vm:/tmp]$ ls -1 | wc -l
3961

extract from repeating errors in gui-vm journalctl

[ghaf@gui-vm:/tmp]$ journalctl -n 100
Jan 13 14:07:41 gui-vm sudo[34403]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34403) opened.
Jan 13 14:07:41 gui-vm sudo[34403]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33964/fd
Jan 13 14:07:41 gui-vm sudo[34403]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:41 gui-vm sudo[34403]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:41 gui-vm sudo[34409]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34409) opened.
Jan 13 14:07:41 gui-vm sudo[34409]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33965/fd
Jan 13 14:07:41 gui-vm sudo[34409]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:41 gui-vm sudo[34409]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:41 gui-vm sudo[34415]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34415) opened.
Jan 13 14:07:41 gui-vm sudo[34415]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33969/fd
Jan 13 14:07:41 gui-vm sudo[34415]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:41 gui-vm sudo[34415]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:41 gui-vm sudo[34421]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34421) opened.
Jan 13 14:07:41 gui-vm sudo[34421]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33970/fd
Jan 13 14:07:41 gui-vm sudo[34421]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:41 gui-vm sudo[34421]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:41 gui-vm sudo[34427]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34427) opened.
Jan 13 14:07:41 gui-vm sudo[34427]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33972/fd
Jan 13 14:07:41 gui-vm sudo[34427]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:41 gui-vm sudo[34427]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:41 gui-vm systemd[33806]: waypipe-chrome.service: Scheduled restart job, restart counter is at 11.
Jan 13 14:07:41 gui-vm systemd[33806]: waypipe-zathura.service: Scheduled restart job, restart counter is at 11.
Jan 13 14:07:41 gui-vm systemd[33806]: waypipe-gala.service: Scheduled restart job, restart counter is at 11.
Jan 13 14:07:41 gui-vm systemd[33806]: waypipe-comms.service: Scheduled restart job, restart counter is at 11.
Jan 13 14:07:41 gui-vm systemd[33806]: waypipe-business.service: Scheduled restart job, restart counter is at 11.
Jan 13 14:07:41 gui-vm systemd[33806]: Started Waypipe for business.
Jan 13 14:07:41 gui-vm systemd[33806]: Started Waypipe for chrome.
Jan 13 14:07:41 gui-vm systemd[33806]: Started Waypipe for comms.
Jan 13 14:07:41 gui-vm systemd[33806]: Started Waypipe for gala.
Jan 13 14:07:41 gui-vm systemd[33806]: Started Waypipe for zathura.
Jan 13 14:07:42 gui-vm waypipe[34433]: C34433: 62.151425 [src/util.c:250] Error binding socket at gui-chrome-vm.sock: Address already in use
Jan 13 14:07:42 gui-vm waypipe[34432]: C34432: 62.151483 [src/util.c:250] Error binding socket at gui-business-vm.sock: Address already in use
Jan 13 14:07:42 gui-vm waypipe[34434]: C34434: 62.151688 [src/util.c:250] Error binding socket at gui-comms-vm.sock: Address already in use
Jan 13 14:07:42 gui-vm waypipe[34436]: C34436: 62.152567 [src/util.c:250] Error binding socket at gui-zathura-vm.sock: Address already in use
Jan 13 14:07:42 gui-vm waypipe[34435]: C34435: 62.152832 [src/util.c:250] Error binding socket at gui-gala-vm.sock: Address already in use
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-chrome.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-chrome.service: Failed with result 'exit-code'.
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-comms.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-comms.service: Failed with result 'exit-code'.
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-gala.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-gala.service: Failed with result 'exit-code'.
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-business.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-business.service: Failed with result 'exit-code'.
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-zathura.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:42 gui-vm systemd[33806]: waypipe-zathura.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-chrome.service: Scheduled restart job, restart counter is at 12.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-business.service: Scheduled restart job, restart counter is at 12.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-zathura.service: Scheduled restart job, restart counter is at 12.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-gala.service: Scheduled restart job, restart counter is at 12.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-comms.service: Scheduled restart job, restart counter is at 12.
Jan 13 14:07:43 gui-vm systemd[33806]: Started Waypipe for business.
Jan 13 14:07:43 gui-vm systemd[33806]: Started Waypipe for chrome.
Jan 13 14:07:43 gui-vm systemd[33806]: Started Waypipe for comms.
Jan 13 14:07:43 gui-vm systemd[33806]: Started Waypipe for gala.
Jan 13 14:07:43 gui-vm systemd[33806]: Started Waypipe for zathura.
Jan 13 14:07:43 gui-vm waypipe[34452]: C34452: 63.422502 [src/util.c:250] Error binding socket at gui-business-vm.sock: Address already in use
Jan 13 14:07:43 gui-vm waypipe[34456]: C34456: 63.422697 [src/util.c:250] Error binding socket at gui-zathura-vm.sock: Address already in use
Jan 13 14:07:43 gui-vm waypipe[34455]: C34455: 63.423070 [src/util.c:250] Error binding socket at gui-gala-vm.sock: Address already in use
Jan 13 14:07:43 gui-vm waypipe[34454]: C34454: 63.422976 [src/util.c:250] Error binding socket at gui-comms-vm.sock: Address already in use
Jan 13 14:07:43 gui-vm waypipe[34453]: C34453: 63.422886 [src/util.c:250] Error binding socket at gui-chrome-vm.sock: Address already in use
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-business.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-business.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-chrome.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-chrome.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-gala.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-gala.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-comms.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-comms.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-zathura.service: Main process exited, code=exited, status=1/FAILURE
Jan 13 14:07:43 gui-vm systemd[33806]: waypipe-zathura.service: Failed with result 'exit-code'.
Jan 13 14:07:43 gui-vm sudo[34466]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34466) opened.
Jan 13 14:07:43 gui-vm sudo[34466]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33964/fd
Jan 13 14:07:43 gui-vm sudo[34466]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:43 gui-vm sudo[34466]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:43 gui-vm sudo[34472]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34472) opened.
Jan 13 14:07:43 gui-vm sudo[34472]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33965/fd
Jan 13 14:07:43 gui-vm sudo[34472]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:43 gui-vm sudo[34472]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:43 gui-vm sudo[34479]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34479) opened.
Jan 13 14:07:43 gui-vm sudo[34479]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33969/fd
Jan 13 14:07:43 gui-vm sudo[34479]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:43 gui-vm sudo[34479]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:44 gui-vm sudo[34485]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34485) opened.
Jan 13 14:07:44 gui-vm sudo[34485]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33970/fd
Jan 13 14:07:44 gui-vm sudo[34485]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:44 gui-vm sudo[34485]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:44 gui-vm sudo[34492]: pam_systemd_home(sudo:account): New sd-bus connection (system-bus-pam-systemd-home-34492) opened.
Jan 13 14:07:44 gui-vm sudo[34492]:     ghaf : TTY=pts/0 ; PWD=/tmp ; USER=root ; COMMAND=/run/current-system/sw/bin/ls /proc/33972/fd
Jan 13 14:07:44 gui-vm sudo[34492]: pam_unix(sudo:session): session opened for user root(uid=0) by ghaf(uid=1001)
Jan 13 14:07:44 gui-vm sudo[34492]: pam_unix(sudo:session): session closed for user root
Jan 13 14:07:44 gui-vm systemd[33806]: waypipe-business.service: Scheduled restart job, restart counter is at 13.
Jan 13 14:07:44 gui-vm systemd[33806]: waypipe-comms.service: Scheduled restart job, restart counter is at 13.
Jan 13 14:07:44 gui-vm systemd[33806]: waypipe-zathura.service: Scheduled restart job, restart counter is at 13.
Jan 13 14:07:44 gui-vm systemd[33806]: waypipe-gala.service: Scheduled restart job, restart counter is at 13.
Jan 13 14:07:44 gui-vm systemd[33806]: waypipe-chrome.service: Scheduled restart job, restart counter is at 13.
Jan 13 14:07:44 gui-vm systemd[33806]: Started Waypipe for business.
Jan 13 14:07:44 gui-vm systemd[33806]: Started Waypipe for chrome.
Jan 13 14:07:44 gui-vm systemd[33806]: Started Waypipe for comms.
Jan 13 14:07:44 gui-vm systemd[33806]: Started Waypipe for gala.
Jan 13 14:07:44 gui-vm systemd[33806]: Started Waypipe for zathura.

jkuro-tii · 2025-01-14T09:14:39Z

Updated the systemd kill signal for Waypipe: it now uses SIGINT. Waypipe properly removes its sockets after receiving the SIGINT signal, whereas it previously received SIGTERM at logout.
The issue with the waypipe* files in /tmp persisting after exiting Waypipe on the gui-vm is unrelated to this PR. This issue also occurs on the main branch.

leivos-unikie · 2025-01-14T11:47:16Z

Tested again on Lenovo-X1

The bug is fixed.

bat tests pass

Monitored now all VMs with the test script while starting all apps and closing them. Number of file descriptors change as noticed before. Nothing suspicious there.

johannarautanen · 2025-01-15T07:10:46Z

Checked with native Orin AGX and NX

build can be done
Ghaf booted up
applications launched
automation test cases were ok

Notes:

so far the build size flashed to the memory stick has been about 7-8GB, with this PR the size is 11-12 GB

johannarautanen · 2025-01-15T07:11:25Z

Checked with crosscompile Orin AGX and NX'

Issues:

cannot create the build fro AGX or NX

leivos-unikie · 2025-02-27T06:40:43Z

That old bug "VM apps (running outside gui.vm) don't launch after log out and log in" is back again although it was fixed at some point. (See comments on Jan 13 - 14.)

johannarautanen · 2025-02-27T08:13:13Z

Checked with native Orin AGX and NX
Working:

builds can be done
Ghaf booted up and ghaf-screen visible on the external display
applications launched
automation test cases were ok

vadika · 2025-02-28T08:07:11Z

modules/reference/personalize/authorizedSshKeys.nix

@@ -28,7 +28,7 @@
    "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAINfyjcPGIRHEtXZgoF7wImA5gEY6ytIfkBeipz4lwnj6 [email protected]"
    "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIMsRi+yikYJjpLhJZHlCb9N4Wb7fHUEh0Y6XekD9DyTQ [email protected]"
    "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIEA7p7hHPvPT6uTU44Nb/p9/DT9mOi8mpqNllnpfawDE tanel@nixos"
-
+    "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIIwGPH/oOrD1g15uiPV4gBKGk7f8ZBSyMEaptKOVs3NG jaroslawkurowski@TII-JaroslawKurowski"


Lets move it to separate commit?

jkuro-tii · 2025-02-28T08:16:40Z

That old bug "VM apps (running outside gui.vm) don't launch after log out and log in" is back again although it was fixed at some point. (See comments on Jan 13 - 14.)

The bug is related to the PR I have raised. Even after fixing the issue by removing Waypipe tmp files, quickly logging out and back in still blocks services. I can provide a temporary workaround, but I believe fixing the root cause in the mentioned PR is the better approach

jkuro-tii · 2025-03-03T06:53:30Z

Added removal waypipe of /tmp sockets in order to fix problem with re-logging (though the problem with quick re-logging still persists).
Removed adding public ssh key.

Signed-off-by: Jaroslaw Kurowski <[email protected]>

jkuro-tii · 2025-03-06T07:51:59Z

Fixed the logout process. A recent update on the main branch caused a SIGKILL signal to be sent, preventing the proper propagation of the termination event

leivos-unikie · 2025-03-07T11:39:52Z

Tested on Lenovo-X1

test automation passes, performance meters at normal level
number of file descriptors stay within decent range

Didn't encounter the bug anymore (log out - log in - launch app). Removing the bug tag.

brianmcgillion · 2025-03-08T09:08:23Z

modules/hardware/common/shared-mem.nix

+              "gala-vm"
+              "zathura-vm"
+              "comms-vm"
+              "business-vm"


this should be set in the modules/reference/profiles/mvp. because it it not known here in common that these are the enabled vms.

brianmcgillion · 2025-03-08T09:11:07Z

modules/hardware/common/shared-mem.nix

+              "chrome-vm"
+              "business-vm"
+              "comms-vm"
+              "gala-vm"


same as above

brianmcgillion · 2025-03-08T09:13:25Z

modules/hardware/common/shared-mem.nix

        environment.systemPackages = [
-          (pkgs.memsocket.override { vms = cfg.instancesCount; })
+          (pkgs.callPackage ../../../packages/pkgs-by-name/memsocket/package.nix { inherit (cfg) shmSlots; })


do not do this. use the (pkgs.memsocket.override { vms = cfg.shmSlotst; }) method to use the package

jkuro-tii temporarily deployed to internal-build-workflow November 28, 2024 07:53 — with GitHub Actions Inactive

jkuro-tii requested review from mbssrc, josa41 and vadika November 28, 2024 07:53

jkuro-tii marked this pull request as ready for review November 28, 2024 09:00

jkuro-tii force-pushed the shm_multi_server branch from 37d3bb5 to ba95458 Compare January 7, 2025 10:24

jkuro-tii temporarily deployed to internal-build-workflow January 7, 2025 10:24 — with GitHub Actions Inactive

jkuro-tii force-pushed the shm_multi_server branch from ba95458 to 99db384 Compare January 7, 2025 11:51

jkuro-tii temporarily deployed to internal-build-workflow January 7, 2025 11:51 — with GitHub Actions Inactive

josa41 approved these changes Jan 9, 2025

View reviewed changes

jkuro-tii force-pushed the shm_multi_server branch from 99db384 to e0df8c1 Compare January 9, 2025 12:02

jkuro-tii temporarily deployed to internal-build-workflow January 9, 2025 12:02 — with GitHub Actions Inactive

leivos-unikie added the bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR label Jan 13, 2025

jkuro-tii force-pushed the shm_multi_server branch from e0df8c1 to 88a14a4 Compare January 14, 2025 09:11

jkuro-tii temporarily deployed to internal-build-workflow January 14, 2025 09:11 — with GitHub Actions Inactive

leivos-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Jan 14, 2025

brianmcgillion added Needs Testing CI Team to pre-verify bug on Orin AGX Issues found on NVIDIA Jetson AGX Orin while checking this PR bug on Orin NX Issues found on NVIDIA Jetson NX Orin while checking this PR labels Jan 14, 2025

jkuro-tii requested a review from josa41 January 15, 2025 05:24

johannarautanen added Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled labels Feb 27, 2025

leivos-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon labels Feb 27, 2025

vadika suggested changes Feb 28, 2025

View reviewed changes

jkuro-tii force-pushed the shm_multi_server branch from 8080899 to 82daf58 Compare March 3, 2025 06:41

jkuro-tii temporarily deployed to internal-build-workflow March 3, 2025 06:41 — with GitHub Actions Inactive

vadika approved these changes Mar 3, 2025

View reviewed changes

jkuro-tii force-pushed the shm_multi_server branch from 82daf58 to d4c1f8c Compare March 4, 2025 07:21

jkuro-tii temporarily deployed to internal-build-workflow March 4, 2025 07:21 — with GitHub Actions Inactive

jkuro-tii force-pushed the shm_multi_server branch from d4c1f8c to 33457f6 Compare March 5, 2025 05:40

jkuro-tii temporarily deployed to internal-build-workflow March 5, 2025 05:40 — with GitHub Actions Inactive

jkuro-tii force-pushed the shm_multi_server branch from 33457f6 to 3ad180d Compare March 5, 2025 07:38

jkuro-tii temporarily deployed to internal-build-workflow March 5, 2025 07:38 — with GitHub Actions Inactive

Shared memory refactoring. Now gui sent via shm

6f884dc

Signed-off-by: Jaroslaw Kurowski <[email protected]>

jkuro-tii force-pushed the shm_multi_server branch from 3ad180d to 6f884dc Compare March 6, 2025 07:29

jkuro-tii temporarily deployed to internal-build-workflow March 6, 2025 07:29 — with GitHub Actions Inactive

leivos-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Mar 7, 2025

brianmcgillion requested changes Mar 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added shared memory multi-server feature #917

Added shared memory multi-server feature #917

jkuro-tii commented Nov 28, 2024 •

edited

Loading

josa41 commented Nov 28, 2024

mbssrc commented Dec 4, 2024

josa41 commented Jan 9, 2025

jkuro-tii commented Jan 9, 2025

leivos-unikie commented Jan 13, 2025 •

edited

Loading

jkuro-tii commented Jan 14, 2025

leivos-unikie commented Jan 14, 2025

johannarautanen commented Jan 15, 2025

johannarautanen commented Jan 15, 2025

leivos-unikie commented Feb 27, 2025

johannarautanen commented Feb 27, 2025

vadika Feb 28, 2025

jkuro-tii Feb 28, 2025

jkuro-tii commented Feb 28, 2025

jkuro-tii commented Mar 3, 2025

jkuro-tii commented Mar 6, 2025

leivos-unikie commented Mar 7, 2025

brianmcgillion Mar 8, 2025

brianmcgillion Mar 8, 2025

brianmcgillion Mar 8, 2025

Added shared memory multi-server feature #917

Are you sure you want to change the base?

Added shared memory multi-server feature #917

Conversation

jkuro-tii commented Nov 28, 2024 • edited Loading

Description of changes

Checklist for things done

Instructions for Testing

josa41 commented Nov 28, 2024

mbssrc commented Dec 4, 2024

josa41 commented Jan 9, 2025

jkuro-tii commented Jan 9, 2025

leivos-unikie commented Jan 13, 2025 • edited Loading

jkuro-tii commented Jan 14, 2025

leivos-unikie commented Jan 14, 2025

johannarautanen commented Jan 15, 2025

johannarautanen commented Jan 15, 2025

leivos-unikie commented Feb 27, 2025

johannarautanen commented Feb 27, 2025

vadika Feb 28, 2025

Choose a reason for hiding this comment

jkuro-tii Feb 28, 2025

Choose a reason for hiding this comment

jkuro-tii commented Feb 28, 2025

jkuro-tii commented Mar 3, 2025

jkuro-tii commented Mar 6, 2025

leivos-unikie commented Mar 7, 2025

brianmcgillion Mar 8, 2025

Choose a reason for hiding this comment

brianmcgillion Mar 8, 2025

Choose a reason for hiding this comment

brianmcgillion Mar 8, 2025

Choose a reason for hiding this comment

jkuro-tii commented Nov 28, 2024 •

edited

Loading

leivos-unikie commented Jan 13, 2025 •

edited

Loading