Skip to content

Commit

Permalink
mpfs_mpucfg.c: Add mpfs_mpu_lock()
Browse files Browse the repository at this point in the history
Add method to lock an MPUCFG entry. Locking means the value of the register
cannot be changed until the SoC is reset.
  • Loading branch information
pussuw committed Jan 11, 2024
1 parent 3de3eb4 commit f925082
Show file tree
Hide file tree
Showing 2 changed files with 65 additions and 9 deletions.
54 changes: 47 additions & 7 deletions arch/risc-v/src/mpfs/mpfs_mpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@

/* Encode the MPUCFG register value */

#define MPFS_MPUCFG_ENCODE(mode, napot) \
(((mode << MPFS_MPUCFG_MODE_SHIFT) & MPFS_MPUCFG_MODE_MASK) | \
((napot << MPFS_MPUCFG_PMP_SHIFT) & MPFS_MPUCFG_PMP_MASK))
#define MPFS_MPUCFG_ENCODE(mode, napot) \
((((mode) << MPFS_MPUCFG_MODE_SHIFT) & MPFS_MPUCFG_MODE_MASK) | \
(((napot) << MPFS_MPUCFG_PMP_SHIFT) & MPFS_MPUCFG_PMP_MASK))

/* Decode the MPUCFG register value */

Expand Down Expand Up @@ -91,7 +91,7 @@
* size - Size out.
*
* Returned Value:
* Base address
* Base address.
*
****************************************************************************/

Expand Down Expand Up @@ -136,7 +136,7 @@ static void napot_decode(uintptr_t val, uintptr_t *base, uintptr_t *size)
* size must align with each other.
*
* Returned Value:
* 0 on success; negated error on failure
* 0 on success; negated error on failure.
*
****************************************************************************/

Expand Down Expand Up @@ -184,7 +184,7 @@ int mpfs_mpu_set(uintptr_t reg, uintptr_t perm, uintptr_t base,

/* Calculate mode (RWX), only NAPOT encoding is supported */

mode = (perm & PMPCFG_RWX_MASK) | PMPCFG_A_NAPOT;
mode = (perm & (PMPCFG_RWX_MASK | PMPCFG_L)) | PMPCFG_A_NAPOT;

/* Do the NAPOT encoding */

Expand All @@ -210,7 +210,7 @@ int mpfs_mpu_set(uintptr_t reg, uintptr_t perm, uintptr_t base,
* size - The length of the region.
*
* Returned Value:
* true if access OK; false if not
* true if access OK; false if not.
*
****************************************************************************/

Expand Down Expand Up @@ -241,3 +241,43 @@ bool mpfs_mpu_access_ok(uintptr_t reg, uintptr_t perm, uintptr_t base,

return (base >= reg_base && (base + size) <= (reg_base + reg_size));
}

/****************************************************************************
* Name: mpfs_mpu_lock
*
* Description:
* Lock an MPUCFG register from further modifications.
*
* Input Parameters:
* reg - The MPUCFG register to lock.
*
* Returned Value:
* 0 on success; negated error on failure.
*
****************************************************************************/

int mpfs_mpu_lock(uintptr_t reg)
{
uintptr_t mode;
uintptr_t napot;

/* Sanity check the register */

if (reg < MPFS_MPUCFG_BASE || reg >= MPFS_MPUCFG_END)
{
return -EINVAL;
}

MPFS_MPUCFG_DECODE(reg, &mode, &napot);

/* If the entry is already locked, everything is fine */

if ((mode & PMPCFG_L) == 0)
{
/* Set the lock bit and write the value back */

putreg64(MPFS_MPUCFG_ENCODE(mode | PMPCFG_L, napot), reg);
}

return OK;
}
20 changes: 18 additions & 2 deletions arch/risc-v/src/mpfs/mpfs_mpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
* size must align with each other.
*
* Returned Value:
* 0 on success; negated error on failure
* 0 on success; negated error on failure.
*
****************************************************************************/

Expand All @@ -69,11 +69,27 @@ int mpfs_mpu_set(uintptr_t reg, uintptr_t perm, uintptr_t base,
* size - The length of the region.
*
* Returned Value:
* true if access OK; false if not
* true if access OK; false if not.
*
****************************************************************************/

bool mpfs_mpu_access_ok(uintptr_t reg, uintptr_t perm, uintptr_t base,
uintptr_t size);

/****************************************************************************
* Name: mpfs_mpu_lock
*
* Description:
* Lock an MPUCFG register from further modifications.
*
* Input Parameters:
* reg - The MPUCFG register to lock.
*
* Returned Value:
* 0 on success; negated error on failure.
*
****************************************************************************/

int mpfs_mpu_lock(uintptr_t reg);

#endif /* __ARCH_RISC_V_SRC_MPFS_MPFS_MPU_H */

0 comments on commit f925082

Please sign in to comment.