Fix user task exit by exception #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pussuw
reviewed
Mar 19, 2024
pussuw
approved these changes
Mar 19, 2024
jlaitine
force-pushed
the
fix_user_task_exit_by_exception
branch
from
114b7cb to
699c1f5
Compare
pussuw
reviewed
Mar 20, 2024
pussuw
reviewed
Mar 20, 2024
pussuw
approved these changes
Mar 20, 2024
jlaitine
force-pushed
the
fix_user_task_exit_by_exception
branch
from
699c1f5 to
5036d5d
Compare
pussuw
approved these changes
Mar 20, 2024
jlaitine
force-pushed
the
fix_user_task_exit_by_exception
branch
from
5036d5d to
8329991
Compare
pussuw
reviewed
Mar 20, 2024
pussuw
approved these changes
Mar 20, 2024
…force-cancelled There is no point in waiting for children to exit if the parent is force-cancelled Signed-off-by: Jukka Laitinen <[email protected]>
…using an exception We shouldn't panic the kernel when a user task excepts, we can just kill the user task and it's children. Do this by returning to _exit() in kernel context. Signed-off-by: Jukka Laitinen <[email protected]>
… currently running task in risc-v syscall If a context switch occurs in syscall, the g_running_task need to be recorded for assert logic. This copies the logic from arm platforms Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_user_task_exit_by_exception
branch
from
8329991 to
13ea8e1
Compare
|
I reverted the running_task -> this_task change in favor of following the upstream g_running_tasks[thiscpu()] recording method. The reason why g_running_task method was not working was that it needs to be updated every time a context switch occurs, i.e. also in syscalls. Made another Pr for this in upstream: apache#11961. sorry for continuous updates to this PR, I decided to just put this into this same one as this was not yet merged. |
pussuw
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the bugs DP-2143, DP-8522
I will still offer this to upstream review first
Impact
Increase resilience to SW bugs, don't crash the whole system if a userspace process excepts
Testing
Injected NULL dereference bugs in couple of PX4 processes, tried out that they exit without causing a panic.