[BACKPORT] arm64_head.S: Add explicit input section for __start #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As __start must be placed at a precise location, a separate, explicit input section is needed to guarantee this. Why is this an issue ? NuttX uses --entry=__start which puts __start in its correct location, but out-of-tree builds won't work, so it more robust to use an explicit section for the startup code and enforce its placement in the linker script.
jlaitine
approved these changes
Mar 25, 2024
pussuw
pushed a commit
that referenced
this pull request
Aug 27, 2024
"/home/guoshichao/work_profile/vela_os/vela_car_4/nuttx/include/nuttx/net/netdev.h", line 493: warning #231-D: declaration is not visible outside of function FAR struct netdev_ifaddr6_s *addr, ^ Signed-off-by: guoshichao <[email protected]>
pussuw
pushed a commit
that referenced
this pull request
Aug 27, 2024
…f function" warning CC: serial/serial_io.c "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/nuttx/power/regulator.h", line 227: warning #231-D: declaration is not visible outside of function int regulator_gpio_init(FAR struct ioexpander_dev_s *iodev, Signed-off-by: yanghuatao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As __start must be placed at a precise location, a separate, explicit input section is needed to guarantee this.
Why is this an issue ? NuttX uses --entry=__start which puts __start in its correct location, but out-of-tree builds won't work, so it more robust to use an explicit section for the startup code and enforce its placement in the linker script.