[1.13.3 FC_ONLY] USB and I2C fix #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
t-salminen
commented
Mar 26, 2024
t-salminen
commented
- cherry-picked usb patch from mainline
- fixed semaphore race condition in i2c-driver
Currently the irq handler checks many reserved bits, which is a waste of resources: 1. pending_rx_ep bit 0 is reserved (always 0) 2. pending_rx_ep and pending_tx_ep have only bits 1, 2, 3 and 4 defined, no need to scan MPFS_USB_NENDPOINTS (9) bits as the rest are reserved Fix this by checking only the relevant bits. Signed-off-by: Eero Nurkkala <[email protected]>
t-salminen
force-pushed
the
i2c_semaphore_fix
branch
from
d1140a5 to
4e9d942
Compare
jlaitine
reviewed
Mar 27, 2024
jlaitine
requested changes
Mar 27, 2024
MPFS_I2C_ST_STOP_SENT interrupt might be received right after semaphore timeout, which would cause the semaphore to be in the incorrect signaled state when the next transfer starts. Signed-off-by: Tero Salminen <[email protected]>
t-salminen
force-pushed
the
i2c_semaphore_fix
branch
from
4e9d942 to
bc63f61
Compare
|
Added one more patch for corespi-driver to fix similar semaphore race condition as in i2c-driver. |
SPI TX_DONE interrupt can be received after a semaphore timeout, but before interrupts are disabled. This will leave the semaphore to the signaled state. After a timeout the semaphore is always reset to non-signaled state to fix this race condition. Signed-off-by: Tero Salminen <[email protected]>
t-salminen
force-pushed
the
i2c_semaphore_fix
branch
from
545feb5 to
9600ab4
Compare
jlaitine
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.