mpfs_ethernet.c: increase GMAC_RX_UNITSIZE #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnippula
force-pushed
the
mpfs_eth_gmac_rx
branch
from
681403a to
435d0cb
Compare
pussuw
approved these changes
May 28, 2024
Now when you say it, I'll think I'll do that instead, so it would be consistent with the TX buffer. |
jnippula
force-pushed
the
mpfs_eth_gmac_rx
branch
from
435d0cb to
f368c8b
Compare
|
I was thinking is there any reason to use different packet sizes for RX and TX, but just use the same size/config for both? |
To me it would make sense to just use the (Ethernet) MTU for both, shouldn't that be enough ? |
jnippula
force-pushed
the
mpfs_eth_gmac_rx
branch
from
f368c8b to
8662abb
Compare
pussuw
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set RX buffer size to max frame length to be able to receive MC side MTU size frames