arch/arm64/imx9 Usb driver cache #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify cache clean/invalidate to get mass-storage transfer work (WIP) Signed-off-by: Jouni Ukkonen <[email protected]>
jlaitine
reviewed
Sep 25, 2024
| @@ -764,6 +765,9 @@ static inline void imx9_writedtd(struct imx9_dtd_s *dtd, | |||
| const uint8_t *data, | |||
| uint32_t nbytes) | |||
| { | |||
| up_invalidate_dcache((uintptr_t)data, | |||
There was a problem hiding this comment.
This shouldn't be needed, the same is done below
jlaitine
reviewed
Sep 25, 2024
| @@ -776,8 +780,9 @@ static inline void imx9_writedtd(struct imx9_dtd_s *dtd, | |||
|
|
|||
| up_clean_dcache((uintptr_t)dtd, | |||
| (uintptr_t)dtd + sizeof(struct imx9_dtd_s)); | |||
| up_clean_dcache((uintptr_t)data, | |||
| (uintptr_t)data + nbytes); | |||
|
|
|||
There was a problem hiding this comment.
I believe the original line is correct, except for CACHE_ALIGN_UP.
The *3 should not be needed
Perhaps the whole buffer should be invalidated (or cleaned) when it is allocated in imx9_epallocbuffer.
jlaitine
reviewed
Sep 25, 2024
| up_invalidate_dcache((uintptr_t)dtd->buffer0, | ||
| (uintptr_t)dtd->buffer0 + dtd->xfer_len); | ||
| (uintptr_t)dtd->buffer0 + CACHE_ALIGN_UP(dtd->xfer_len)); |
There was a problem hiding this comment.
This part is fishy at best :) Just add the CACHE_ALIGN_UP(), and remove the additional lines below.
buffer1,2,3,4 are adjacent, so if xfer_len is longer than 1 first buffer, then next ones are just invalidated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify cache clean/invalidate to get
mass-storage transfer work (WIP)
Summary
Impact
Testing