libs/libc/modlib/modlib_bind.c: Fix system crash if modlib_bind fails #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something that was broken when libelf was removed ? |
pussuw
reviewed
Feb 13, 2025
jlaitine
force-pushed
the
fix_modlib_bind
branch
from
9063868 to
5de9adf
Compare
linking just fails with one of the PX4 modules in px5 v1.15.3 rebase. The real reason why it fails I didn't study yet; I think this is still worth fixing |
Yes of course worth fixing, I was just wondering is this something that was broken when libelf was removed and replaced by modlib. And to answer my own question, this is exactly what happened.. Thanks for fixing this ! |
Addrenv is changed to the newly created process' one in the beginning of modlib_bind, and needs to be changed always when returning from the function; also in error cases. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_modlib_bind
branch
from
5de9adf to
d377be9
Compare
|
Picked the ~same commit from upstream PR |
pussuw
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addrenv is changed to the newly created process' one in the beginning of modlib_bind, and needs to be changed always when returning from the function; also in error cases.