Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate all code related to Local TSO #8802

Open
JmPotato opened this issue Nov 12, 2024 · 2 comments · Fixed by #8845
Open

Eliminate all code related to Local TSO #8802

JmPotato opened this issue Nov 12, 2024 · 2 comments · Fixed by #8845
Labels
component/tso Timestamp Oracle. type/development The issue belongs to a development tasks

Comments

@JmPotato
Copy link
Member

As we're working on introducing #8690 to the PD client, the code reuse of stream batch-related work is necessary in all kinds of terms. However, some legacy code from the Local TSO feature prevents us from resuing and simplifying the code. Considering that this feature will not be GA anymore due to the current implementation of microservice TSO and its code has been lacking maintenance for a long time, this issue proposes eliminating all code related to Local TSO.

This should bring us these pros:

  • Simplify the TSO code of both the PD server and PD client.
  • Allow us to abstract the PD client infrastructure further.
@JmPotato JmPotato added component/tso Timestamp Oracle. type/development The issue belongs to a development tasks labels Nov 12, 2024
@okJiang
Copy link
Member

okJiang commented Nov 12, 2024

LGTM

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 12, 2024

Great

@JmPotato JmPotato mentioned this issue Nov 12, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 13, 2024
@JmPotato
*: remove the code of Local TSO from PD client (#8803)
ac133d8 
ref #8802

Remove the code of Local TSO from PD client.

Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato mentioned this issue Nov 14, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 14, 2024
@JmPotato
*: remove the Local TSO test cases (#8810)
40ae26c 
ref #8802

Remove the Local TSO test cases.

Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato mentioned this issue Nov 14, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 14, 2024
@JmPotato @ti-chi-bot
readme: remove the TSO consistency test status badge (#8815)
c8c7551 
ref #8802

Remove the TSO consistency test status badge.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@okJiang okJiang mentioned this issue Nov 22, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in be4a366 Nov 22, 2024
@JmPotato JmPotato reopened this Nov 22, 2024
@okJiang okJiang mentioned this issue Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/tso Timestamp Oracle. type/development The issue belongs to a development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tso/local: remove allocatorPatroller/PriorityChecker func okJiang/pd
3 participants
@JmPotato @lhy1024 @okJiang