Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove the Local TSO test cases #8810

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8802.

What is changed and how does it work?

Remove the Local TSO test cases.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/testing CI testing. component/tso Timestamp Oracle. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (2f9bf48) to head (878ac0f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8810      +/-   ##
==========================================
- Coverage   75.33%   75.16%   -0.17%     
==========================================
  Files         459      459              
  Lines       71843    71843              
==========================================
- Hits        54123    54001     -122     
- Misses      14285    14382      +97     
- Partials     3435     3460      +25     
Flag Coverage Δ
unittests 75.16% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -1,4 +1,4 @@
// Copyright 2021 TiKV Project Authors.
// Copyright 2024 TiKV Project Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original content of tso_test.go has been modified, and the test cases from global_tso_test.go have been added, so I simply consider it a new file.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 06:05:28.47341533 +0000 UTC m=+509090.664284327: ☑️ agreed by rleungx.
  • 2024-11-14 06:35:25.28930319 +0000 UTC m=+510887.480172184: ☑️ agreed by okJiang.

@JmPotato
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit 40ae26c into tikv:master Nov 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/testing CI testing. component/tso Timestamp Oracle. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants