Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix trace #8847

Merged
merged 4 commits into from
Nov 25, 2024
Merged

client: fix trace #8847

merged 4 commits into from
Nov 25, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 25, 2024

What problem does this PR solve?

Issue Number: Close #8534

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2024
@rleungx
Copy link
Member Author

rleungx commented Nov 25, 2024

/cc @zyguan

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

@rleungx: GitHub didn't allow me to request PR reviews from the following users: zyguan.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zyguan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

@zyguan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 25, 2024
@rleungx
Copy link
Member Author

rleungx commented Nov 25, 2024

/retest

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.74%. Comparing base (21a04cb) to head (dc0688e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8847      +/-   ##
==========================================
- Coverage   75.74%   75.74%   -0.01%     
==========================================
  Files         460      460              
  Lines       70693    70693              
==========================================
- Hits        53547    53543       -4     
- Misses      13761    13770       +9     
+ Partials     3385     3380       -5     
Flag Coverage Δ
unittests 75.74% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 06:03:57.011122984 +0000 UTC m=+443624.630777495: ☑️ agreed by nolouch.
  • 2024-11-25 06:52:18.761152315 +0000 UTC m=+446526.380806866: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit 52b42b2 into tikv:master Nov 25, 2024
23 of 25 checks passed
@rleungx rleungx deleted the fix-trace branch November 25, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misuse of trace region in tso_dispatcher
4 participants