cluster: avoiding large numbers of logs in check tso service #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
rleungx
approved these changes
Nov 26, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8855 +/- ##
==========================================
- Coverage 75.74% 75.68% -0.07%
==========================================
Files 460 460
Lines 70693 70695 +2
==========================================
- Hits 53547 53504 -43
- Misses 13761 13802 +41
- Partials 3385 3389 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
nolouch
approved these changes
Nov 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: lhy1024 <[email protected]>
lhy1024
added
the
needs-cherry-pick-release-8.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
bot
removed
the
needs-cherry-pick-release-8.5
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…8857) close #8854 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8854 ref #8477
What is changed and how does it work?
Check List
Tests
without unexpect log
Release note