Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize import format #339

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Normalize import format #339

wants to merge 3 commits into from

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Sep 18, 2023

Normalize import format by the rule which is used by TiKV

Signed-off-by: Connor1996 <[email protected]>
@Connor1996
Copy link
Member Author

PTAL as well @LykxSassinator

Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: Patch coverage is 99.00990% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.22%. Comparing base (fa56f89) to head (eeb3a35).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/engine.rs 97.22% 1 Missing ⚠️
src/filter.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files          33       33           
  Lines       12446    12501   +55     
=======================================
+ Hits        12224    12279   +55     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add format to stable CI and see if it can pass too. This crate is used not limited to nightly compiler.

Copy link

ti-chi-bot bot commented Nov 5, 2024

@Connor1996: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rust-nightly eeb3a35 link true /test rust-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants