fix(tableau-server-linux-backup): do not proceed when tsm raises error #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of weeks ago, we saw some errors in our backup process. By drilling down, we found out that the
tsmcommand was not working correctly (because of issues on the server side). So, instead of returning the expected output, it returned some error logs. And on the later step (when it cleans up the old backups), it was trying to clean up the path which didn't exist (and it can be risky as well since it may delete some critical files/folders).TLDR
If
tsmcommand output has an error, exit and don't continue the script.