Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JobCollection #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor JobCollection #17

wants to merge 4 commits into from

Conversation

UlrichEckhardt
Copy link
Contributor

  • Make the collection itself iterable.
  • In methods that took a JobCollection as parameter, use a more liberal Traversable<Job> instead. This allows using other, compatible types as well, in particular generators.

@UlrichEckhardt
JobCollection.php: Make the collection iterable
faa8026 
This allows using it in a simple `foreach` loop. Also, add a missing
`void` return type annotation.
@UlrichEckhardt
SingleProcessingStrategy: Use Traversable<Job> instead of JobCollection
8d03132
@UlrichEckhardt
ForkingProcessingStrategy: Use Traversable<Job> instead of JobCollection
6545bef
@UlrichEckhardt
ProcessingStrategy: Don't hardcode a JobCollection as parameter in th…
17159e3 
…e interface

Instead, allow any iterator over a sequence of `Job`, which makes this
a bit more flexible. In particular, it allows use of a `Generator`.
@UlrichEckhardt UlrichEckhardt mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UlrichEckhardt