Skip to content

Commit

Permalink
chore: comment on 10.15 compatiblity
Browse files Browse the repository at this point in the history
  • Loading branch information
tillt committed Dec 20, 2023
1 parent ca291f1 commit 5aaa3d2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions KompleteSynthesia/MIDIController.m
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ - (BOOL)setupWithError:(NSError**)error
[weakSelf receivedMIDIEvents:evtlist interface:kMIDIConnectionInterfaceLightLoopback];
};

// MIDIInputPortCreateWithProtocol does not exist on macOS 10.15. We could replace this
// logic with `MIDIInputPortCreateWithBlock` which works based on MIDIPackets and not
// MIDIEvents - that in turn makes the parser a more complex and prone to failurea. But
// it would give us 10.15 (catalina) compatiblity.
status = MIDIInputPortCreateWithProtocol(client,
(__bridge CFStringRef)kMIDIInputInterfaceLightLoopback,
kMIDIProtocol_1_0,
Expand Down

0 comments on commit 5aaa3d2

Please sign in to comment.