fix(node-version): downgrade node to fix broken cdk pipelines [INFRA-…

…33946] (#315) * fix(node-version): downgrade node to fix broken cdk pipelines [INFRA-33946] * add tests for using workflowNodeVersion
time-loop · Feb 7, 2025 · 89e92c9 · 89e92c9
1 parent d8a0dc3
commit 89e92c9
Show file tree

Hide file tree

Showing 14 changed files with 68 additions and 42 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
diff --git a/.github/workflows/update-projen-main.yml b/.github/workflows/update-projen-main.yml
diff --git a/.npmrc b/.npmrc
diff --git a/.nvmrc b/.nvmrc
diff --git a/src/clickup-cdk.ts b/src/clickup-cdk.ts
@@ -184,7 +184,7 @@ export module clickupCdk {
         // pnpm will manage the version of the package manager (pnpm)
         this.npmrc.addConfig('manage-package-manager-versions', 'true');
         // pnpm checks this value before running commands and will use (and install if missing) the specified version
-        this.npmrc.addConfig('use-node-version', parameters.PROJEN_NODE_VERSION);
+        this.npmrc.addConfig('use-node-version', options.workflowNodeVersion ?? parameters.PROJEN_NODE_VERSION);
         // PNPM support for bundledDeps https://pnpm.io/npmrc#node-linker
         this.npmrc.addConfig('node-linker', 'hoisted');
       }
@@ -298,7 +298,7 @@ export module clickupCdk {
         // necessary to allow minor/patch version updates of pnpm on dev boxes
         this.npmrc.addConfig('package-manager-strict', 'false');
         // pnpm checks this value before running commands and will use (and install if missing) the specified version
-        this.npmrc.addConfig('use-node-version', parameters.PROJEN_NODE_VERSION);
+        this.npmrc.addConfig('use-node-version', options.workflowNodeVersion ?? parameters.PROJEN_NODE_VERSION);
       }
     }
   }

diff --git a/src/clickup-ts.ts b/src/clickup-ts.ts
@@ -246,7 +246,7 @@ export module clickupTs {
         // pnpm will manage the version of the package manager (pnpm)
         this.npmrc.addConfig('manage-package-manager-versions', 'true');
         // pnpm checks this value before running commands and will use (and install if missing) the specified version
-        this.npmrc.addConfig('use-node-version', parameters.PROJEN_NODE_VERSION);
+        this.npmrc.addConfig('use-node-version', options.workflowNodeVersion ?? parameters.PROJEN_NODE_VERSION);
       }
     }
   }

diff --git a/src/utils/parameters.ts b/src/utils/parameters.ts
@@ -9,7 +9,7 @@ export class parameters {
 
   // This should be updated occasionally to the latest release of the current active version.
   // This will drive all the other node versions throughout the system.
-  static PROJEN_NODE_VERSION: string = '22.13.1';
+  static PROJEN_NODE_VERSION: string = '20.11.1';
 
   // This should be updated occasionally to the latest release of the current active version.
   static PROJEN_PNPM_VERSION: string = '9.15.5';

diff --git a/test/__snapshots__/cdk-diff-workflow.test.ts.snap b/test/__snapshots__/cdk-diff-workflow.test.ts.snap
diff --git a/test/__snapshots__/clickup-cdk.test.ts.snap b/test/__snapshots__/clickup-cdk.test.ts.snap
diff --git a/test/__snapshots__/clickup-ts.test.ts.snap b/test/__snapshots__/clickup-ts.test.ts.snap
diff --git a/test/__snapshots__/node-version.test.ts.snap b/test/__snapshots__/node-version.test.ts.snap
diff --git a/test/clickup-cdk.test.ts b/test/clickup-cdk.test.ts
@@ -65,7 +65,7 @@ describe('ClickUpCdkTypeScriptApp', () => {
       const npmrcEntries = [
         'package-manager-strict=false',
         // 'manage-package-manager-versions=true',
-        'use-node-version=22.13.1',
+        'use-node-version=20.11.1',
       ];
       it.each(npmrcEntries)('%s', (npmrcEntry) => {
         expect(synth['.npmrc']).toContain(npmrcEntry);
@@ -133,13 +133,25 @@ describe('ClickUpCdkConstructLibrary', () => {
       const npmrcEntries = [
         'package-manager-strict=false',
         'manage-package-manager-versions=true',
-        'use-node-version=22.13.1',
+        'use-node-version=20.11.1',
         'node-linker=hoisted',
       ];
       it.each(npmrcEntries)('%s', (npmrcEntry) => {
         expect(synth['.npmrc']).toContain(npmrcEntry);
       });
     });
+
+    describe('workflowNodeVersion', () => {
+      p = new clickupCdk.ClickUpCdkConstructLibrary({
+        ...commonProps,
+        packageManager: javascript.NodePackageManager.PNPM,
+        workflowNodeVersion: '22.0.0',
+      });
+      const synth = Testing.synth(p);
+      it('use-node-version in .npmrc file', () => {
+        expect(synth['.npmrc']).toContain('use-node-version=22.0.0');
+      });
+    });
   });
 });
 

diff --git a/test/clickup-ts.test.ts b/test/clickup-ts.test.ts
@@ -126,12 +126,26 @@ describe('ClickUpTypeScriptProject', () => {
     const npmrcEntries = [
       'package-manager-strict=false',
       'manage-package-manager-versions=true',
-      'use-node-version=22.13.1',
+      'use-node-version=20.11.1',
     ];
     it.each(npmrcEntries)('%s', (npmrcEntry) => {
       expect(synth['.npmrc']).toContain(npmrcEntry);
     });
   });
+
+  describe('workflowNodeVersion', () => {
+    const p = new clickupTs.ClickUpTypeScriptProject({
+      name: '@time-loop/test',
+      defaultReleaseBranch: 'main',
+      packageManager: javascript.NodePackageManager.PNPM,
+      pnpmVersion: '9',
+      workflowNodeVersion: '22.0.0',
+    });
+    const synth = Testing.synth(p);
+    it('use-node-version in .npmrc file', () => {
+      expect(synth['.npmrc']).toContain('use-node-version=22.0.0');
+    });
+  });
 });
 
 describe('normalizeName', () => {