Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unused_tuple lint under the new dead_code name #654

Closed
wants to merge 1 commit into from

Conversation

rillian
Copy link

@rillian rillian commented Feb 1, 2024

As of at least rust 1.77 nightly, the compiler warns that the unused_tuple_struct_field lint has been subsumed under dead_code. Allow both lints in the relevant field here.

This still warns about the old name on nightly but helps with the severity of the warning for those building with a nightly toolchain and is less likely regress builds with future stable toolchains.

As of at least rust 1.77 nightly, the compiler warns that the
`unused_tuple_struct_field` lint has been subsumed under
`dead_code`. Allow both lints in the relevant field here.

This still warns about the old name on nightly but helps
with the severity of the warning for those building with a
nightly toolchain and is less likely regress builds with
future stable toolchains.
@jhpratt
Copy link
Member

jhpratt commented Feb 2, 2024

Lints in time follow the latest stable, as that is what is used both in CI and when I am working on code. Formatting is the only thing that requires nightly, with documentation only using it for additional (non-essential) functionality.

It seems as though you think that users relying on time as a dependency will be shown this lint. That is thankfully not the case. Lints are only shown for the end crate and any path dependencies. Lints also don't stop working when renamed — they continue working as before, just with an additional lint (about the renaming) being emitted.

For these reasons, I'll be holding off until this reaches stable.

@jhpratt jhpratt closed this Feb 2, 2024
@jhpratt jhpratt added the A-core Area: anything not otherwise covered label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: anything not otherwise covered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants