Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the date_time method on struct DateTimeOffset public #705

Closed
wants to merge 2 commits into from

Conversation

PolpOnline
Copy link

I don't know what were the motivations behind it being private (if any)

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.6%. Comparing base (4a74924) to head (a9db86c).
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #705     +/-   ##
=======================================
- Coverage   97.8%   97.6%   -0.2%     
=======================================
  Files         81      83      +2     
  Lines       9378    9008    -370     
=======================================
- Hits        9169    8790    -379     
- Misses       209     218      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhpratt
Copy link
Member

jhpratt commented Sep 5, 2024

I recommend you search before opening a pull request; this has been denied repeatedly.

#369
#390
#395
#454
#458
#553
#658
#673

@jhpratt jhpratt closed this Sep 5, 2024
@jhpratt jhpratt added C-duplicate Category: exact duplicate C-invalid Category: no issue exists or the issue cannot be reproduced labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-duplicate Category: exact duplicate C-invalid Category: no issue exists or the issue cannot be reproduced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants