Skip to content

Commit

Permalink
Remove replication_factor references
Browse files Browse the repository at this point in the history
  • Loading branch information
jonatas committed Apr 9, 2024
1 parent 2bfb31f commit 97a4a75
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
5 changes: 1 addition & 4 deletions docs/command_line.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ Tick.hypertable
num_chunks: 1,
compression_enabled: false,
is_distributed: false,
replication_factor: nil,
data_nodes: nil,
tablespaces: nil>
```

Expand All @@ -119,8 +117,7 @@ unknown OID 2206: failed to recognize type of 'primary_dimension_type'. It will
range_start_integer: nil,
range_end_integer: nil,
is_compressed: false,
chunk_tablespace: nil,
data_nodes: nil>]
chunk_tablespace: nil>]
```

> Chunks are created by partitioning the hypertable data into one
Expand Down
11 changes: 1 addition & 10 deletions spec/timescaledb/database/schema_statements_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,6 @@
end
end

context 'when passing integer params' do
it 'returns expected SQL' do
expect(
described_class.create_hypertable_sql('events', 'created_at', replication_factor: 3)
).to eq("SELECT create_hypertable('events', 'created_at', replication_factor => 3);")
end
end

context 'when passing string params' do
it 'returns expected SQL' do
optional_params = {
Expand All @@ -67,7 +59,6 @@
it 'returns expected SQL' do
optional_params = {
if_not_exists: true,
replication_factor: 3,
partitioning_column: 'category',
number_partitions: 3,
partitioning_func: 'category_func',
Expand All @@ -76,7 +67,7 @@

expect(
described_class.create_hypertable_sql('events', 'created_at', **optional_params)
).to eq("SELECT create_hypertable('events', 'created_at', 'category', 3, if_not_exists => 'TRUE', replication_factor => 3, partitioning_func => 'category_func', distributed => 'FALSE');")
).to eq("SELECT create_hypertable('events', 'created_at', 'category', 3, if_not_exists => 'TRUE', partitioning_func => 'category_func', distributed => 'FALSE');")
end
end
end
Expand Down
1 change: 0 additions & 1 deletion spec/timescaledb/migration_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"is_distributed" => false,
"num_chunks" => 0,
"num_dimensions" => 1,
"replication_factor" => nil,
"tablespaces" => nil})
end
end
Expand Down

0 comments on commit 97a4a75

Please sign in to comment.