-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update helm release node-feature-discovery to v0.17.1 #400
Open
timtor-bot
wants to merge
1
commit into
main
Choose a base branch
from
renovate/node-feature-discovery-0.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44e817c
to
7fc6bac
Compare
7fc6bac
to
d765076
Compare
d765076
to
28633be
Compare
28633be
to
e4ab172
Compare
e4ab172
to
f3c3799
Compare
f3c3799
to
879ae92
Compare
879ae92
to
d5eac73
Compare
d5eac73
to
9f5128d
Compare
9f5128d
to
243b8d0
Compare
--- kubernetes/kube-system Kustomization: flux-system/1-kube-system HelmRelease: kube-system/node-feature-discovery
+++ kubernetes/kube-system Kustomization: flux-system/1-kube-system HelmRelease: kube-system/node-feature-discovery
@@ -11,13 +11,13 @@
chart:
spec:
chart: node-feature-discovery
sourceRef:
kind: HelmRepository
name: node-feature-discovery
- version: 0.15.4
+ version: 0.17.1
install:
crds: CreateReplace
interval: 1h
maxHistory: 1
timeout: 1m0s
upgrade: |
--- HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
+++ HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
@@ -1,13 +0,0 @@
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
- name: node-feature-discovery-topology-updater-conf
- namespace: kube-system
- labels:
- app.kubernetes.io/name: node-feature-discovery
- app.kubernetes.io/instance: node-feature-discovery
- app.kubernetes.io/managed-by: Helm
-data:
- nfd-topology-updater.conf: 'null'
-
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
@@ -5,12 +5,19 @@
name: node-feature-discovery
labels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
rules:
+- apiGroups:
+ - ''
+ resources:
+ - namespaces
+ verbs:
+ - watch
+ - list
- apiGroups:
- ''
resources:
- nodes
- nodes/status
verbs:
@@ -20,16 +27,24 @@
- list
- apiGroups:
- nfd.k8s-sigs.io
resources:
- nodefeatures
- nodefeaturerules
+ - nodefeaturegroups
verbs:
- get
- list
- watch
+- apiGroups:
+ - nfd.k8s-sigs.io
+ resources:
+ - nodefeaturegroups/status
+ verbs:
+ - patch
+ - update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
--- HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery Role: kube-system/node-feature-discovery-worker
@@ -14,7 +14,14 @@
resources:
- nodefeatures
verbs:
- create
- get
- update
+ - delete
+- apiGroups:
+ - ''
+ resources:
+ - pods
+ verbs:
+ - get
--- HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
@@ -7,12 +7,13 @@
labels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: worker
spec:
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: worker
template:
@@ -22,23 +23,33 @@
app.kubernetes.io/instance: node-feature-discovery
role: worker
spec:
dnsPolicy: ClusterFirstWithHostNet
serviceAccountName: node-feature-discovery-worker
securityContext: {}
+ hostNetwork: false
containers:
- name: worker
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.4
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.1
imagePullPolicy: IfNotPresent
+ livenessProbe:
+ grpc:
+ port: 8082
+ initialDelaySeconds: 10
+ readinessProbe:
+ grpc:
+ port: 8082
+ initialDelaySeconds: 5
+ failureThreshold: 10
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: POD_NAME
@@ -46,20 +57,29 @@
fieldRef:
fieldPath: metadata.name
- name: POD_UID
valueFrom:
fieldRef:
fieldPath: metadata.uid
- resources: {}
+ resources:
+ limits:
+ memory: 512Mi
+ requests:
+ cpu: 5m
+ memory: 64Mi
command:
- nfd-worker
args:
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
+ - -grpc-health=8082
ports:
- - name: metrics
- containerPort: 8081
+ - containerPort: 8081
+ name: metrics
+ - containerPort: 8082
+ name: health
volumeMounts:
- name: host-boot
mountPath: /host-boot
readOnly: true
- name: host-os-release
mountPath: /host-etc/os-release
@@ -70,14 +90,14 @@
- name: host-usr-lib
mountPath: /host-usr/lib
readOnly: true
- name: host-lib
mountPath: /host-lib
readOnly: true
- - name: source-d
- mountPath: /etc/kubernetes/node-feature-discovery/source.d/
+ - name: host-proc-swaps
+ mountPath: /host-proc/swaps
readOnly: true
- name: features-d
mountPath: /etc/kubernetes/node-feature-discovery/features.d/
readOnly: true
- name: nfd-worker-conf
mountPath: /etc/kubernetes/node-feature-discovery
@@ -95,15 +115,15 @@
- name: host-usr-lib
hostPath:
path: /usr/lib
- name: host-lib
hostPath:
path: /lib
- - name: source-d
+ - name: host-proc-swaps
hostPath:
- path: /etc/kubernetes/node-feature-discovery/source.d/
+ path: /proc/swaps
- name: features-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/features.d/
- name: nfd-worker-conf
configMap:
name: node-feature-discovery-worker-conf
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
@@ -8,12 +8,13 @@
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: master
spec:
replicas: 1
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: master
template:
@@ -23,50 +24,58 @@
app.kubernetes.io/instance: node-feature-discovery
role: master
spec:
serviceAccountName: node-feature-discovery
enableServiceLinks: false
securityContext: {}
+ hostNetwork: false
containers:
- name: master
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.4
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.1
imagePullPolicy: IfNotPresent
+ startupProbe:
+ grpc:
+ port: 8082
+ failureThreshold: 30
livenessProbe:
grpc:
- port: 8080
- initialDelaySeconds: 10
- periodSeconds: 10
+ port: 8082
readinessProbe:
grpc:
- port: 8080
- initialDelaySeconds: 5
- periodSeconds: 10
+ port: 8082
failureThreshold: 10
ports:
- - containerPort: 8080
- name: grpc
- containerPort: 8081
name: metrics
+ - containerPort: 8082
+ name: health
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-master
- resources: {}
+ resources:
+ limits:
+ memory: 4Gi
+ requests:
+ cpu: 100m
+ memory: 128Mi
args:
- - -crd-controller=true
+ - -enable-leader-election
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
+ - -grpc-health=8082
volumeMounts:
- name: nfd-master-conf
mountPath: /etc/kubernetes/node-feature-discovery
readOnly: true
volumes:
- name: nfd-master-conf
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
@@ -8,12 +8,13 @@
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
app.kubernetes.io/managed-by: Helm
role: gc
spec:
replicas: 1
+ revisionHistoryLimit: null
selector:
matchLabels:
app.kubernetes.io/name: node-feature-discovery
app.kubernetes.io/instance: node-feature-discovery
role: gc
template:
@@ -23,26 +24,32 @@
app.kubernetes.io/instance: node-feature-discovery
role: gc
spec:
serviceAccountName: node-feature-discovery-gc
dnsPolicy: ClusterFirstWithHostNet
securityContext: {}
+ hostNetwork: false
containers:
- name: gc
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.4
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.1
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-gc
args:
- -gc-interval=1h
- resources: {}
+ resources:
+ limits:
+ memory: 1Gi
+ requests:
+ cpu: 10m
+ memory: 128Mi
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
--- HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
@@ -0,0 +1,14 @@
+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
@@ -0,0 +1,24 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+rules:
+- apiGroups:
+ - ''
+ resources:
+ - nodes
+ - nodes/status
+ verbs:
+ - get
+ - patch
+ - update
+ - list
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
@@ -0,0 +1,21 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+roleRef:
+ apiGroup: rbac.authorization.k8s.io
+ kind: ClusterRole
+ name: node-feature-discovery-prune
+subjects:
+- kind: ServiceAccount
+ name: node-feature-discovery-prune
+ namespace: kube-system
+
--- HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
@@ -0,0 +1,66 @@
+---
+apiVersion: batch/v1
+kind: Job
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+spec:
+ template:
+ metadata:
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ role: prune
+ spec:
+ serviceAccountName: node-feature-discovery-prune
+ containers:
+ - name: nfd-master
+ securityContext:
+ allowPrivilegeEscalation: false
+ capabilities:
+ drop:
+ - ALL
+ readOnlyRootFilesystem: true
+ runAsNonRoot: true
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.17.1
+ imagePullPolicy: IfNotPresent
+ command:
+ - nfd-master
+ args:
+ - -prune
+ restartPolicy: Never
+ affinity:
+ nodeAffinity:
+ preferredDuringSchedulingIgnoredDuringExecution:
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/master
+ operator: In
+ values:
+ - ''
+ weight: 1
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/control-plane
+ operator: In
+ values:
+ - ''
+ weight: 1
+ tolerations:
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/master
+ operator: Equal
+ value: ''
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/control-plane
+ operator: Equal
+ value: ''
+ |
b4e53f8
to
4182870
Compare
4182870
to
d99fabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.15.4
->0.17.1
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes-sigs/node-feature-discovery (node-feature-discovery)
v0.17.1
Compare Source
This patch release makes it possible to run NFD in clusters where the OwnerReferencesPermissionEnforcement admission controller has been enabled. The release also contains bug fixes to the experimental
nfd
image compatibility tool.Full Changelog: kubernetes-sigs/node-feature-discovery@v0.17.0...v0.17.1
v0.17.0
Compare Source
Changelog
Configurable restrictions (EXPERIMENTAL)
The nfd-master now has configuration options to restrict its capabilities, that is what modifications on node objects are allowed. See the nfd-master configuration file reference for documentation.
Image compatibity (EXPERIMENTAL)
There is an initiative to utilize NFD to implement system compatibility requirements for container images. As part of this work NFD v0.17 includes
nfd
command line client for validating systems against image compatibility manifests. See the documentation for more details, including examples how to create container images with compatibility manifests and validating nodes.See the enhancement proposal for background information and design details.
Miscellaneous
Scalability
This release contains numerous fixes to fix issues and improve the scalability of NFD in larger clusters.
DMI features
Discovery of
system.dmiid.product_name
was added.CPUID features
Support for new CPUID flags were added, including AMX-FP8 and AVX-VNNI-INT16.
Helm chart
Numerous small improvements in the NFD Helm chart, mainly new configuration values (see chart parameters for documentation).
Deprecations
gRPC API
The NodeFeature API is now GA and the legacy gRPC API has been completely removed.
Hooks
Support for hooks (deprecated in v0.12 has been removed. See the customization guide for replacements.
ResourceLabels config option
The
resourceLabels
configuration file option (and the corresponding-resource-labels
flag), deprecated in v0.13 were removed. Use NodeFeatureRule object's extendedResources field instead.Dynamic configuration
Dynamic runt-time reconfiguration was removed. This improves robustness and consistency as some of the configuration options did not support dynamic configuration.
Upcoming changes
The separate metric and health ports will be united behind a single port and the corresponding Helm chart values will be removed in NFD v0.18. This should be invisible to most users.
List of PRs
(Full Changelog: kubernetes-sigs/node-feature-discovery@v0.17.0-devel...v0.17.0)
v0.16.7
Compare Source
What's Changed
This patch release updates dependencies and makes it possible to run NFD in clusters where the OwnerReferencesPermissionEnforcement admission controller has been enabled.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.6...v0.16.7
v0.16.6
Compare Source
What's Changed
Contributors @marquiz @elezar @ArangoGutierrez
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.5...v0.16.6
v0.16.5
Compare Source
What's Changed
Fixes an nfd-master memory leak on re-configure events when leader election is enabled. Adds parameters to configure health endpoint port.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.4...v0.16.5
v0.16.4
Compare Source
What's Changed
This patch release contains improvements to the Helm chart, adding configurable liveness and readiness probes for all daemons and configurable revision history limit for the nfd-worker and nfd-topology-updater.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.3...v0.16.4
v0.16.3
Compare Source
Fix detection of swap in some scenarios (#1751) and add Helm parameter to set the revisionHistoryLimit of nfd-master and nfd-gc (#1759).
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.2...v0.16.3
v0.16.2
Compare Source
What's Changed
Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.1...v0.16.2
v0.16.1
Compare Source
What's Changed
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.16.0...v0.16.1
v0.16.0
: v0.16Compare Source
Changelog
NodeFeatureGroup API
The NodeFeatureGroup custom resource was added to the NFD API. The NodeFeatureGroup API enables the creation of node groups based on features discovered by NFD. The API is an alpha feature and is disabled by default and can be enabled with the NodeFeatureGroupAPI feature gate.
See documentation for more details.
Feature gates
NFD adapted the concept of feature gates from Kubernetes to introduce and stabilize new features in a controlled way. See the documentation for more details. Two existing features (NodeFeature API and disabling label auto-prefixing) were converted into feature gates.
Deprecations
Upcoming changes
Support for hooks is deprecated since v0.12.0 and will be completely dropped in the NFD v0.17.
RDT feature labels removed
The
feature.node.kubernetes.io/cpu-rdt.*
feature labels that were deprecated in NFD v0.13 were removed. RDT features are still available for use in NodeFeatureRules for custom labels.Deprecated flags and options
The autoDefaultNs config file option of nfd-master is deprecated and will be removed in NFD v0.17. Superseded by the DisableAutoPrefix feature gate (
featureGates.DisableAutoPrefix
Helm parameter).The
-enable-nodefeature-api
command line flag of nfd-master and nfd-worker and the correspondingenableNodeFeatureApi
Helm chart parameter have been deprecated and will be removed in NFD v0.17. Superseded by the NodeFeature API feature gate (featureGates.NodeFeatureAPI
Helm parameter).The
-crd-controller
command line flag of nfd-master is deprecated and will be removed with the gRPC API in a future release.Miscellaneous
Network devices
Discover speed of virtual network interfaces.
DMI
Added support for detecting DMI attributes from
/sys/devices/virtual/dmi/id/
. In v0.16 onlysys_vendor
discovered, available assystem.dmiid.sys_vendor
feature for use in NodeFeatureRules.Swap
Discover the availability of swap on the node. Available as
memory.swap.enabled
feature for use in NodeFeatureRules.Helm chart
Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook.
The Helm chart now sets resource requests (cpu and memory) for NFD pods. Users may want to adjust these for their cluster. An option to set the pod priority class was added. See Helm chart parameters in the documentation).
Container health
A gRPC health server was added to the nfd-master, nfd-worker and nfd-topology-updater daemons. Deployments (Helm and kustomize) configure container liveness and readiness probes to use that for health checking.
List of PRs
nfd-worker
erroring when reading attributes from paravirtual devices (#1557)v0.15.7
Compare Source
What's Changed
This patch release updates dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.6...v0.15.7
v0.15.6
Compare Source
What's Changed
Fixes an issue where node labels were temporarily removed on nfd-worker pod restarts.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.5...v0.15.6
v0.15.5
Compare Source
Changelog
This patch release fixes nfd-topology-updater on IPv6 clusters.
List of PRs
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.