Include project root directory in file path when rm-ing #4
Conversation
| [{:keys [checkout] :as project} & [pattern]] | ||
| (let [current-checkouts (fs/list-dir "checkouts") | ||
| [{:keys [checkout root] :as project} & [pattern]] | ||
| (let [current-checkouts (fs/list-dir (str root File/separator "checkouts")) |
There was a problem hiding this comment.
This should probably be (fs/file root "checkouts")
|
Thanks for the feedback. I've updated the PR to use |
| @@ -1,6 +1,7 @@ | |||
| (ns leiningen.checkout.rm | |||
| (:require [fs.core :as fs] | |||
| [leiningen.checkout.utils :as utils])) | |||
| [leiningen.checkout.utils :as utils]) | |||
| (:import (java.io File))) | |||
There was a problem hiding this comment.
Is there a reason we're still importing File?
There was a problem hiding this comment.
Whoops, I forgot I added that. Thanks for catching it. I'll get that removed!
|
Hi @timvisher, are there any other modifications you'd like me to make for this PR? |
|
@sashton Sorry just getting back from a vacation. I'll try to get to this sometime today. :) |
|
Finally figured out the issue that I was having and documented it here #6 I should be able to verify these today and get them merged. Thanks for your patience! |
|
Alright this all looks great. Unfortunately I'm going to have to relearn how to publish to clojars. I'll do that asap. |
Fix for #3