add golangci-lint checks #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Errors were detected with:
find . -name go.mod | sed s/go.mod// | xargs -I{} sh -c 'cd {}; GOOS=linux golangci-lint run --path-prefix {} --fix ./...'
Initial problems captured at https://gist.github.com/displague/94aa6e20a2aba10adc6582222acd6ee5
Signed-off-by: Marques Johansson <[email protected]>
|
Can you give it a try with https://github.com/tinkerbell/lint-install instead? It should already have support for multiple modules and has golangci-lint config that is applied to other go repos in this org which will help to keep the code bases consistent with each other. It also supports other files types that are in this repo and would be good to have linted also. |
|
Actually I messed around with doing this and have a bunch of other quick/misc things to fix needed. Give me a minute and I'll get my changes up for PR too. |
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
|
Closing for #78 See #78 (comment) for more details |
mergify bot
added a commit
that referenced
this pull request
May 3, 2022
## Description This PR mostly just makes use of https://github.com/tinkerbell/lint-install. Some nixpkgs stuff came along for the ride as we were using a quite old pin. I've cleaned up some of the code in hack/ci-check.sh so its clearer and produces better output if `go mod tidy` makes changes. I also fixed a bug in .gitignore that would have caused new files in cmd/hub to be ignored. ## Why is this needed I was prodded into this due to #77, which is using a different golangci-lint config than other projects and also doesn't lint other files. ## How Has This Been Tested? `make lint` passes and `docker buildx build` worked for me on all the images. ## How are existing users impacted? What migration steps/scripts do we need? Cleaner and/or more consistent code under tinkerbell/ org. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds golangci-lint checks.
Because this project contains many sub-packages with their own go.mod file, a work-around was needed (copied from a comment on the relevant issue: golangci/golangci-lint#828 (comment)).
Why is this needed
This prevents the need for humans leaving common go review comments, many of which may be nitpics that would otherwise be dismissed resulting in poor code quality over time.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: