menu: faster background drawing using FastHLines #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved menu's background drawing by using a customized version of
FilledTriangle
, which relies onDrawFastHLine
rather than pixel-by-pixel line drawing.I have mixed feelings:
tinydraw
DrawFastHLine
FilledTriangle
here, but if you have a better solution I'd love to hear about.I'm a beginner with go, so there may be a trick I don't know 😉
The aim of this PR is mostly to have your feedback.
Overall there's a lot of potential in performance improvement with batching pixel drawings and using driver-specific functions when available, but I guess if there was an easy way to do it it would already be done 🤷