net: implement ResolveIPAddr with a stub for lookupProtocol #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Stewart <[email protected]>
|
Okay, after a couple fixes, got it right now 👍🏽 |
scottfeldman
requested changes
Apr 9, 2024
| // See func [Dial] for a description of the network and address | ||
| // parameters. | ||
| func ResolveIPAddr(network, address string) (*IPAddr, error) { | ||
| if network == "" { // a hint wildcard for Go 1.0 undocumented behavior |
There was a problem hiding this comment.
We can probably skip everything here except returning the "not implemented" error.
| default: | ||
| return nil, UnknownNetworkError(network) | ||
| } | ||
| return nil, errors.New("tcpsock:ResolveIPAddr not implemented") |
| // | ||
| // See func [Dial] for a description of the network and address | ||
| // parameters. | ||
| func ResolveIPAddr(network, address string) (*IPAddr, error) { |
There was a problem hiding this comment.
Move this func to iprawsock.go please. I'm trying to keep things aligned with where things are in the upstream src/net repo, for comparison sake.
|
Hi @paralin, added PR#36 to resolve this PR. PR#36 has the review changes. Mostly just moved changes into proper files to keep synced with Go upstream. |
|
Ok see #36 then 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.