Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netdev #3614

Closed
wants to merge 12 commits into from
Closed

Netdev #3614

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc9dfb2
Add network device driver model, netdev
scottfeldman Mar 27, 2023
e1de929
move IPPROTO_TLS to netdev to avoid src/syscall dependency
scottfeldman Mar 28, 2023
63b78b2
udpsock: remove TODO comment on ephemeral ports being racy
scottfeldman Apr 1, 2023
1d2106f
Makefile: remove net package from tests to workaround Windows failure
scottfeldman Apr 1, 2023
155ada5
Makefile: revert removing net package from test for Windows
scottfeldman Apr 1, 2023
c71f208
loader: add windows to targets to merge syscall package
scottfeldman Apr 2, 2023
d89f431
loader: revert adding windows to syscall package merge
scottfeldman Apr 3, 2023
42c2d3c
BUG Fix: return proper net.OpError's for Read/Write operations
scottfeldman Apr 16, 2023
b758967
BUG Fix: use port :80 if server.Addr is empty
scottfeldman Apr 26, 2023
a48baf2
move syscall constants for networking into net space to avoid windows…
scottfeldman May 2, 2023
0bc2aa6
Unexport net constants copied over from syscall
scottfeldman May 3, 2023
a78026e
Merge branch 'tinygo-org:release' into netdev3
scottfeldman Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/net/tcpsock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ func ResolveTCPAddr(network, address string) (*TCPAddr, error) {
return nil, fmt.Errorf("Network '%s' not supported", network)
}

switch address {
case ":http":
address = ":80"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does native (upstream) Go default to port 80 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here's the doc for Addr in http.Server:

type Server struct {
	// Addr optionally specifies the TCP address for the server to listen on,
	// in the form "host:port". If empty, ":http" (port 80) is used.
	// The service names are defined in RFC 6335 and assigned by IANA.
	// See net.Dial for details of the address format.
	Addr string

}

// TINYGO: Use netdev resolver

host, sport, err := SplitHostPort(address)
Expand Down