Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade nx-cloud #2959

Merged
merged 2 commits into from
Oct 24, 2023
Merged

downgrade nx-cloud #2959

merged 2 commits into from
Oct 24, 2023

Conversation

drakang4
Copy link
Contributor

PR 설명

chore: downgrade nx-cloud

변경 내역

nx-cloud runner가 원래는 access token이 없으면 default runner로 동작했었는데
16.5.0 버전부터 access token이 필수가 되어버린 것 같습니다.
CI에는 토큰이 설정 되어 있지만 로컬에서 개발할 때는 토큰 설정 없이 default runner를 써야하기 때문에 16.4.0으로 고정해서 써봅니다.

@drakang4 drakang4 self-assigned this Oct 23, 2023
@drakang4 drakang4 requested a review from a team as a code owner October 23, 2023 10:44
@drakang4 drakang4 requested review from dongoc, sohnjunior and dia-triple and removed request for a team October 23, 2023 10:44
@drakang4 drakang4 added this to the v13.9.0 milestone Oct 23, 2023
@drakang4 drakang4 changed the title chore: downgrade nx-cloud downgrade nx-cloud Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bc9e53) 12.18% compared to head (d62b336) 12.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2959   +/-   ##
=======================================
  Coverage   12.18%   12.18%           
=======================================
  Files         687      687           
  Lines       36201    36201           
  Branches     8938     8938           
=======================================
  Hits         4410     4410           
  Misses      31784    31784           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dongoc dongoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하! 이래서 lint나 build 돌릴 때 access token 에러가 나왔던 거군요😂

@drakang4 drakang4 merged commit ee3e192 into main Oct 24, 2023
7 checks passed
@drakang4 drakang4 deleted the downgrade-nx-cloud branch October 24, 2023 01:29
@choisohyun choisohyun modified the milestones: v13.9.0, v13.8.1 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants