Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] RoomMetadata의 타입을 변경합니다. #2939

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[Chat] RoomMetadata의 타입을 변경합니다. #2939

merged 2 commits into from
Oct 13, 2023

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Oct 10, 2023 •
edited
Loading

PR 설명

RoomMetadata의 타입을 변경합니다.

  • 채팅 공지사항을 faq가 아닌 article로 관리함에 따라 RoomMetadata의 faqId가 articleId로 변경되었습니다.
  • RoomMetadata는 room의 type이 event일 때만 존재하므로 옵셔널 값으로 변경합니다.

@dongoc dongoc added the chat label Oct 10, 2023
@dongoc dongoc added this to the v13.7.0 milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ce8bd99) 12.21% compared to head (a8f2e2c) 12.21%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2939   +/-   ##
=======================================
  Coverage   12.21%   12.21%           
=======================================
  Files         685      685           
  Lines       36113    36113           
  Branches     8919     8919           
=======================================
  Hits         4410     4410           
  Misses      31696    31696           
  Partials        7        7
Files Coverage Δ
packages/chat/src/types/index.ts 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc dongoc marked this pull request as ready for review October 10, 2023 07:03
@dongoc dongoc requested a review from a team as a code owner October 10, 2023 07:03
@dongoc dongoc requested review from zzolain, zhsks528 and torres-triple and removed request for a team October 10, 2023 07:03
@dongoc
Copy link
Contributor Author

dongoc commented Oct 10, 2023

release-canary

@dongoc dongoc requested a review from guswl98 October 10, 2023 07:41
@github-actions
Copy link

v13.6.1-pr-2939.9 has been published!

@choisohyun choisohyun mentioned this pull request Oct 13, 2023
Merged
@dongoc dongoc merged commit f01ff53 into main Oct 13, 2023
12 checks passed
@dongoc dongoc deleted the fix/room-type branch October 13, 2023 01:44
@dongoc dongoc mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guswl98 guswl98 guswl98 approved these changes

@drakang4 drakang4 drakang4 approved these changes

@zzolain zzolain Awaiting requested review from zzolain zzolain is a code owner automatically assigned from titicacadev/frontend

@zhsks528 zhsks528 Awaiting requested review from zhsks528 zhsks528 is a code owner automatically assigned from titicacadev/frontend

@torres-triple torres-triple Awaiting requested review from torres-triple torres-triple is a code owner automatically assigned from titicacadev/frontend

Assignees
No one assigned
Labels
chat
Projects
None yet
Milestone
v13.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dongoc @drakang4 @guswl98